Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-F14-1] InternHub #62

Open
wants to merge 462 commits into
base: master
Choose a base branch
from

Conversation

ashleygoh1
Copy link

InternHub helps Computer Science students manage contact details of companies and interview dates during their internship hunt. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 68.72038% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 74.46%. Comparing base (b896eb0) to head (5748e5a).

❗ Current head 5748e5a differs from pull request most recent head 5e380d4. Consider uploading reports for the commit 5e380d4 to get more accurate results

Files Patch % Lines
src/main/java/seedu/internhub/ui/ViewPanel.java 0.00% 19 Missing ⚠️
src/main/java/seedu/internhub/ui/PersonCard.java 0.00% 16 Missing ⚠️
...seedu/internhub/logic/parser/AddCommandParser.java 69.23% 9 Missing and 3 partials ⚠️
...eedu/internhub/logic/commands/ReminderCommand.java 60.00% 0 Missing and 4 partials ⚠️
...eedu/internhub/logic/parser/EditCommandParser.java 90.47% 2 Missing and 2 partials ⚠️
...main/java/seedu/internhub/model/person/Person.java 69.23% 1 Missing and 3 partials ⚠️
.../java/seedu/internhub/logic/parser/ParserUtil.java 0.00% 1 Missing and 1 partial ⚠️
...va/seedu/internhub/model/person/InterviewDate.java 93.33% 0 Missing and 2 partials ⚠️
src/main/java/seedu/internhub/MainApp.java 0.00% 1 Missing ⚠️
.../seedu/internhub/logic/parser/InternHubParser.java 66.66% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     75.26%   74.46%   -0.80%     
- Complexity      419      532     +113     
============================================
  Files            71       87      +16     
  Lines          1338     1821     +483     
  Branches        126      198      +72     
============================================
+ Hits           1007     1356     +349     
- Misses          301      409     +108     
- Partials         30       56      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eunrcn and others added 10 commits March 27, 2024 21:37
…mber of Days

In this commit, I updated the ReminderCommand and ReminderCommandParser to allow specifying any number of days for filtering upcoming interviews instead of a fixed 3-day period.

Modified the ReminderCommand class to accept a variable number of days through its constructor.
Updated the ReminderCommandParser to parse the user input and pass the specified number of days to the ReminderCommand constructor.
Refactored the execution logic in ReminderCommand to utilize the provided number of days for filtering upcoming interviews.
This change enhances the flexibility of the ReminderCommand feature, allowing users to specify any desired number of days for viewing upcoming interviews.
This commit resolves conflicts that arose from renaming the project from AddressBook to InternHub. The conflicts occurred due to changes in file paths, references, and other dependencies throughout the codebase. Manual intervention was required to reconcile conflicting changes and ensure consistency in the project structure and functionality.
 Resolve conflicts caused by renaming from AddressBook to InternHub
update ViewPanel showing '-' if note is empty
eunrcn and others added 18 commits March 29, 2024 02:03
This commit introduces unit tests for the ReminderCommand class to ensure correct behavior when executing reminder commands and counting list sizes. Additionally, ReminderCommandParserTest is included to verify the functionality of parsing input arguments for the reminder command, handling both valid and invalid inputs as specified in the requirements.
This commit introduces unit tests for the ReminderCommand class to ensure correct behavior when executing reminder commands and counting list sizes. Additionally, ReminderCommandParserTest is included to verify the functionality of parsing input arguments for the reminder command, handling both valid and invalid inputs as specified in the requirements.
This commit introduces unit tests for the ReminderCommand class to ensure correct behavior when executing reminder commands and counting list sizes. Additionally, ReminderCommandParserTest is included to verify the functionality of parsing input arguments for the reminder command, handling both valid and invalid inputs as specified in the requirements.
DG updated to include implementation of NoteCommand
Add ReminderCommandTest and ReminderCommandParserTest
Width of note sequence increased for better visibility
Format changes to DG & resized NoteSequence.puml
replace default link found in HelpWindow to our team's UG link
Update UG with new layout, InterviewDate minor bug fixes
ashleygoh1 and others added 30 commits April 15, 2024 18:19
replace link pointing to addressbook to InternHub
Update Developer's Guide
Added design considerations and diagrams for filter command
Added design considerations and diagrams for filter command
DG updates for filter command
due to interview date being pass today date, the test cases will fail.
we edit the test case to pass the test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants