[CS2103T-W11-2] CCA Manager #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 419 419
=========================================
Files 71 71
Lines 1338 1338
Branches 126 126
=========================================
Hits 1007 1007
Misses 301 301
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Update UserGuide.md
Update User Guide And Upload Photo
* Docs: Updated AboutUs.md Updated according to https://nus-cs2103-ay2324s2.github.io/website/schedule/week7/project.html It is not completed, we require other members to add their profile pictures. * Update AboutUs.md
…es documentation (#14) * Accomplish 2 tasks given regarding Developer Guide * Fixed minor typo Realised you've enabled others to edit so yay * Docs: Formatting 1. Standardised `EXCO Member` by replacing references to `CCA Organiser` with `EXCO Member` 2. Replaced Use Case documentation with verbatim code blocks so that it looks somewhat nicer in markbind 3. Backticked glossary terms --------- Co-authored-by: alphajae11 <leejaegeun20#gmail.com> Co-authored-by: Jules <[email protected]> Co-authored-by: Jules <[email protected]>
* Add Ken Jin's profile picture * Use correct naming style
* Accomplish 2 tasks given regarding Developer Guide * Fixed minor typo Realised you've enabled others to edit so yay * Docs: Formatting 1. Standardised `EXCO Member` by replacing references to `CCA Organiser` with `EXCO Member` 2. Replaced Use Case documentation with verbatim code blocks so that it looks somewhat nicer in markbind 3. Backticked glossary terms * Add my profile picture in AboutUs.md --------- Co-authored-by: alphajae11 <leejaegeun20#gmail.com> Co-authored-by: Jules <[email protected]> Co-authored-by: Jules <[email protected]>
* Comply with .png format Change the names of the following images: chuahjiajie.jpg -> chuahjiajie.png Additionally, the image source for the "Lifu" profile was adjusted to the .png file instead of the .jpg file. * Remove "title:" Including "title:" was evoking an error. * Add Deliverables and Deadlines Role Appended "Deliverables and Deadlines" role to profile of Chuah Jia Jie. --------- Co-authored-by: chuahjiajie <[email protected]>
* Comply with .png format Change the names of the following images: chuahjiajie.jpg -> chuahjiajie.png Additionally, the image source for the "Lifu" profile was adjusted to the .png file instead of the .jpg file. * Remove "title:" Including "title:" was evoking an error. * Add Deliverables and Deadlines Role Appended "Deliverables and Deadlines" role to profile of Chuah Jia Jie. * Add "title:" Back Added the "title:" portion back to the AboutUs file. --------- Co-authored-by: chuahjiajie <[email protected]>
* Docs: Update non-functional requirements. * Fix spacing --------- Co-authored-by: Ken Jin <[email protected]>
* Add CCA CLI Syntax * Add CCA Object * Edit Person to Include CCA * Add ParseUtil Compliance with CCA * Edit Add Command Made Add Command comply with CCA. * Edit Edit Command * Edit Edit Parser * Create JsonAdaptedCCA * Edit JsonAdaptedPerson * Edit SampleDataUtil * Fix CLI Prefix * Edit Json Files and Fix Issue Edited Json Files to comply with new "CCA" parameter. Additionally, fixed an issue with CCA class. Issue was that validation regex was incorrect and did not accept whitespace. * Add CCA to UI * Fix JsonAdaptedPerson Neglected to add a few lines to the constructor. * Fix Add Command Error * Fix Existing Tests * Add CCA Test * fix tests * Refactor to follow checkstyle.xml * Rename appropriate files * Refactor to pass checkstyle check --------- Co-authored-by: Ken Jin <[email protected]> Co-authored-by: Jules <[email protected]>
* Accomplish 2 tasks given regarding Developer Guide * Fixed minor typo Realised you've enabled others to edit so yay * Docs: Formatting 1. Standardised `EXCO Member` by replacing references to `CCA Organiser` with `EXCO Member` 2. Replaced Use Case documentation with verbatim code blocks so that it looks somewhat nicer in markbind 3. Backticked glossary terms * Add my profile picture in AboutUs.md * Add Assign Command as a part of v1.2 * Adhere to code standards * Adhere to java checkstyle * Adhere to java checkstyle standard * Adhere to java checkstyle standard for AssignCommandParser * Add some test for AssignCommand * Add some test for AssignCommandParserTest * Updated AssignCommand with CCAs --------- Co-authored-by: alphajae11 <leejaegeun20#gmail.com> Co-authored-by: Jules <[email protected]> Co-authored-by: Jules <[email protected]> Co-authored-by: Ken Jin <[email protected]>
* Update small change on UserGuide.md to meet with tp Dashboard * Update UserGuide.md relate to filter tags * Update UserGuide.md in milestone v1.2 Describe the new feature function in UserGuide and provide the format of the command. Images examples will be provided when the final version is done.
* Update CCA class into diagram * Update CCA class into diagram
* Improved per-feature template and started refactoring UG * Major refactor of UG * Cleanup
* Fix multiple issues 1. Error when `charge` does nothing. 2. Error when `cca_delete` tries to delete a CCA that does not exist. 3. Correct `ChargeCommand.MESSAGE_USAGE`. 4. Correct `DeleteCcaCommand.MESSAGE_USAGE`. 5. Added details to `FilterCommand.MESSAGE_USAGE`. 6. Correct `OweCommand.MESSAGE_USAGE`. 7. Fix parsing for OweCommand where multiple `m/` were allowed but not handled. * Improve message for DeleteCcaCommand * Fix wrong parsing of AddCommand and EditCommand
* Fix the email domain bug * Update Email.java * Fix Email test * Fix test issue
* Fix Name Accepting Numbers * Fix Tests Whitespace test can be removed because .trim() is applied to the input. So a string with only whitespace is invalid by default. Have also checked a name that is only whitespace is valid testing the app itself.
* Fix the email domain bug * Update Email.java * Fix Email test * Fix test issue * Add more tests and fix the tiny Javadoc errors * Add acknowledgement in test and more tests on emailTest * Fix name
* Partially filled command formats Still need to add `info`, `warnings` and `tips` * Fix header level
* Add phone validator Ensure all phone numbers have 8 digits according to Singapore phone number format * Edit according to the feedback given by my teammates
--------- Co-authored-by: Ken Jin <[email protected]>
* Add navigation throughout the user guide * Fix checkstyle
…out CCA (#204) * Fix JavaDocs * Fix Assign without CCA * Change AddCommandTest
Co-authored-by: Ken Jin <[email protected]> Co-authored-by: chuahjiajie <[email protected]>
* Improve formatting (mostly) * Improve formatting (mostly) * Update docs/UserGuide.md Co-authored-by: Ken Jin <[email protected]> * Update docs/UserGuide.md Co-authored-by: Ken Jin <[email protected]> * Address comments * Add a TODO --------- Co-authored-by: Ken Jin <[email protected]>
* Change Assign to Append * Fix Assign Command Previous iteration did not prevent adding of roles correctly. Could still add a role when there was not a CCA. Additionally, there would be many strange errors after. * Remove Broken Test This test does not comply with current version of assign * Fix Checkstyle
… from a Contact (#213) * Fix EditCommand Made sure the edit command properly checks if the person has a CCA before adding a role. * Change Edit Command Edit command now automatically deletes roles of a person if a persons CCA is removed via "c/nil". Also deleted some test.
#216) * Update UG * Update CCA_Delete
* Fix DG * Fix DG More
* Fix find command screenshot * make CCA required * fix many bugs * last fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCA Manager helps CCA exco and members manage CCA contacts easily. This app is meant for CLI users.