[CS2103-F12-2] PressPlanner #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
=============================================
- Coverage 75.26% 44.91% -30.35%
- Complexity 419 466 +47
=============================================
Files 71 121 +50
Lines 1338 2498 +1160
Branches 126 262 +136
=============================================
+ Hits 1007 1122 +115
- Misses 301 1332 +1031
- Partials 30 44 +14 ☔ View full report in Codecov by Sentry. |
to address issue #150
Added logic to correctly update the persons attribute of an article to fit the new edited author and sources attributes. Added logic to save the sample data as json files on startup. Did not add a fix for incorrect editing of duplicate named articles.
Added logic to throw errors when a date is out of bound instead of automatically rounding it down. Added new error messages for empty headline, date and status fields.
Unsure if additional error messages are allowable at this stage. Reverted for the time being.
Changes include: * Change title from `AB-3` to `PressPlanner` * Add description for sort article command * Add user stories to the corresponding table * Delete certain extensions in use case which does not follow current program behavior
* This bug was flagged by a tester in the PE-D and after some manual testing, it was discovered to not only apply to the `list -a` command, but also all article commands in general. * The bug can be categorized as a functional bug as it was already mentioned in the UG that "extra whitespaces in the `list -a` command was handled by the program before the feature freeze. * The bug only occurs when there are 2/3 whitespaces after the command word and before the `-a` flag. * The change was made to line 52 of the `AddressBookParser` class.
This reverts commit 99d8b7a.
Add assertions to articlematchestagPredicate to improve defensibility. Fix style error in Typical Predicates. Add test cases for test method.
Add new class to test predicate class.
Properly display images for lookup person/article before
* master: Align image Update image names Add persons preamble and emojis Enlarge some UML diagrams in DG Edit UG callout box titles Edit size of Model Class diagram Change blockquotes to div Fix wrong examples given in manual testing for DG Reduce font size for Model Class diagram Initial attempt at replacing blockquote with div Remove scaling of Model Class diagram Reformat Model Class diagram Delete all dead code in classes # Conflicts: # docs/UserGuide.md
Formatting for PDF
* master:
* master: First Attempt for UG
FIx logic diagram
Crop images
Move page break
Finalize the DG by adding and organizing info
Update UG format
Add blank lines between each planned enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PressPlanner helps freelance journalists streamline their workflow by organizing sources, tracking outlets interested in their stories, and managing collaborations with peers/editors. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands.