Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-F12-2] PressPlanner #90

Open
wants to merge 578 commits into
base: master
Choose a base branch
from

Conversation

Murugan-Maniish
Copy link

PressPlanner helps freelance journalists streamline their workflow by organizing sources, tracking outlets interested in their stories, and managing collaborations with peers/editors. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 10.44444% with 403 lines in your changes are missing coverage. Please review.

Project coverage is 44.91%. Comparing base (b896eb0) to head (1091d08).

❗ Current head 1091d08 differs from pull request most recent head 79ae62d. Consider uploading reports for the commit 79ae62d to get more accurate results

Files Patch % Lines
...main/java/seedu/address/model/article/Article.java 0.00% 51 Missing ⚠️
...commands/articlecommands/FilterArticleCommand.java 0.00% 25 Missing ⚠️
src/main/java/seedu/address/ui/ArticleCard.java 0.00% 24 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 22 Missing ⚠️
...c/main/java/seedu/address/model/article/Title.java 0.00% 22 Missing ⚠️
...c/commands/articlecommands/EditArticleCommand.java 0.00% 21 Missing ⚠️
...va/seedu/address/logic/commands/LookupCommand.java 0.00% 19 Missing ⚠️
...commands/articlecommands/LookupArticleCommand.java 0.00% 19 Missing ⚠️
...s/model/article/ArticleMatchesStatusPredicate.java 0.00% 16 Missing ⚠️
...rc/main/java/seedu/address/model/article/Link.java 0.00% 15 Missing ⚠️
... and 26 more
Additional details and impacted files
@@              Coverage Diff              @@
##             master      #90       +/-   ##
=============================================
- Coverage     75.26%   44.91%   -30.35%     
- Complexity      419      466       +47     
=============================================
  Files            71      121       +50     
  Lines          1338     2498     +1160     
  Branches        126      262      +136     
=============================================
+ Hits           1007     1122      +115     
- Misses          301     1332     +1031     
- Partials         30       44       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ko-Khan and others added 29 commits April 10, 2024 17:06
Added logic to correctly update the persons attribute of an article to
fit the new edited author and sources attributes.

Added logic to save the sample data as json files on startup.

Did not add a fix for incorrect editing of duplicate named articles.
Added logic to throw errors when a date is out of bound instead of
automatically rounding it down.

Added new error messages for empty headline, date and status fields.
Unsure if additional error messages are allowable at this stage.
Reverted for the time being.
Changes include:

* Change title from `AB-3` to `PressPlanner`
* Add description for sort article command
* Add user stories to the corresponding table
* Delete certain extensions in use case which does not follow current
 program behavior
* This bug was flagged by a tester in the PE-D and after some
manual testing, it was discovered to not only apply to the `list -a`
command, but also all article commands in general.
* The bug can be categorized as a functional bug as it was already
mentioned in the UG that "extra whitespaces in the `list -a` command
was handled by the program before the feature freeze.
* The bug only occurs when there are 2/3 whitespaces after the command
word and before the `-a` flag.
* The change was made to line 52 of the `AddressBookParser` class.
Add assertions to
articlematchestagPredicate
to improve defensibility.

Fix style error in Typical
Predicates.

Add test cases for test method.
Add new class to test predicate class.
H4mes and others added 30 commits April 15, 2024 19:24
Properly display images for lookup person/article before
* master:
  Align image
  Update image names
  Add persons preamble and emojis
  Enlarge some UML diagrams in DG
  Edit UG callout box titles
  Edit size of Model Class diagram
  Change blockquotes to div
  Fix wrong examples given in manual testing for DG
  Reduce font size for Model Class diagram
  Initial attempt at replacing blockquote with div
  Remove scaling of Model Class diagram
  Reformat Model Class diagram
  Delete all dead code in classes

# Conflicts:
#	docs/UserGuide.md
Finalize the DG by adding and organizing info
Add blank lines between each planned enhancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants