Extract printWelcomeMessage method#86
Open
AmeliaTYR wants to merge 2 commits intonus-cs2113-AY2021S1:masterfrom
Open
Extract printWelcomeMessage method#86AmeliaTYR wants to merge 2 commits intonus-cs2113-AY2021S1:masterfrom
AmeliaTYR wants to merge 2 commits intonus-cs2113-AY2021S1:masterfrom
Conversation
NeilBaner
suggested changes
Aug 28, 2020
|
|
||
| try { | ||
| int phoneNumber = Integer.parseInt(phone); | ||
| return (phoneNumber > 79999999 && phoneNumber < 100000000); |
There was a problem hiding this comment.
Some phone numbers, particularly landlines, do start with 6 so I would change this a bit.
Author
There was a problem hiding this comment.
I updated it! Though I'm not sure if the try-catch thing is the right way to deal with non integer phone numbers or if there's a better way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code to print welcome message