forked from se-edu/duke
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DateTime functionality #329
Open
0xEljh
wants to merge
19
commits into
nus-cs2113-AY2021S1:master
Choose a base branch
from
0xEljh:branch-Level-8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User input was only echoed back. Update parses user input, maintains a list of tasks that can be retrieved on command.
Main interfaced directly with TaskList and only Tasks could be created. Introduced todos, events, and deadlines as new types of tasks that can be added with more details. Task manager now parses user input and puts a barrier between Duke and TaskList/other task implementations.
TaskManager now informs user of errors due to erroneous user input: Missing command words, not enough arguments, and invalid int/index.
"at" and "by" keywords added to compliment existing keywords which had "/" prefixes.
Branch level 5
Delete task from task list by providing its index.
Output class removes cyclic dependency of TaskManager and Duke. Output class will be used to further streamline the TaskManager class so that it does not need to handle parsing, commands, and outputs all together.
Branch level 6
add Save and Retrieve tasks
Refactored code in main to improve readability
Streamlined methods in TaskManager by having Output class handle all printing. Extracted repeated/similar functionality in addEvent and addDeadline
User can input find <keyword(s)> to get a list of tasks that contain the keywords (case insensitive)
add Find based on keyword match
Event and deadline now support ISO dates as details. New class DateType is new parent class to deadline and event to support this
Find (dated) tasks with matching dates when user queries for a date in ISO format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deadline and event support understand dates when entered in ISO format.
Users can query for tasks with matching dates via
dated <date in ISO format>
command.