Skip to content

[CS2113T-F11-1] The Schwarzenegger #113

Open
tienkhoa16 wants to merge 977 commits intonus-cs2113-AY2021S1:masterfrom
AY2021S1-CS2113T-F11-1:master
Open

[CS2113T-F11-1] The Schwarzenegger #113
tienkhoa16 wants to merge 977 commits intonus-cs2113-AY2021S1:masterfrom
AY2021S1-CS2113T-F11-1:master

Conversation

@tienkhoa16
Copy link
Copy Markdown

PR subject: The Schwarzenegger

The Schwarzenegger helps people keep track of their daily workout routines and daily nutritional intake. It is optimized for CLI users so that recording can be done faster by typing in commands.

Copy link
Copy Markdown

@thatseant thatseant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi good job on the DG! Left some comments...

Comment thread docs/pictures/zesong/DeleteWS.puml
Comment thread docs/pictures/zesong/model.puml
Comment thread docs/pictures/zesong/NewWS.puml
Comment thread src/main/java/commands/CommandLib.java Outdated
@1-Karthigeyan-1
Copy link
Copy Markdown

image
Under 4.2.2 viewing a profile , is it possible to explain the difference between the 2 result outcomes in the optional pathway?

@1-Karthigeyan-1
Copy link
Copy Markdown

1-Karthigeyan-1 commented Oct 29, 2020

image

I believe there might be a typo for PastRecordList.

@1-Karthigeyan-1
Copy link
Copy Markdown

image
Under 4.4.1.2. Deleting an Exercise, the implementation and the diagram does not mention the delete functionality.

Copy link
Copy Markdown

@Zhangyilin0203 Zhangyilin0203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good job!

Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Copy link
Copy Markdown

@yuqiaoluolong yuqiaoluolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are sufficient diagrams and most are well drawn.

Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Comment thread docs/DeveloperGuide.md Outdated
Copy link
Copy Markdown

@qkbrandon qkbrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed, very nice.

yujinyang1998 and others added 30 commits November 9, 2020 22:57
remove line from uml diagram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants