[Yap Joon Siong] iP by yapjoonsiong · Pull Request #186 · nus-cs2113-AY2122S1/ip

yapjoonsiong · 2021-09-01T07:54:02Z

No description provided.

…the user and exits.

…, simply echos commands entered by the user, and exits when the user types bye.

…y them back to the user when requested.

…lity. Add varying responses for adding tasks.

…d output

teoziyiivy

Good code overall! It's cool that your program has random responses, very interesting :)

teoziyiivy · 2021-09-03T06:33:59Z

src/main/java/Tasks.java

+public class Tasks {
+    Task list[] = new Task[100];
+    int listLength = 0;
+    int tasksIncomplete = 0;


incompleteTasks might be a better variable name here.

teoziyiivy · 2021-09-03T06:40:16Z

src/main/java/Duke.java

+        System.out.println("\tNow you have " + user.listLength + " tasks in the list, " + user.tasksIncomplete + " incomplete tasks");
+    }
+    public static void addDeadline(String input, Tasks user) {
+        user.list[user.listLength] = new Deadline(input.substring(9, input.indexOf("/") - 1), input.substring(input.indexOf("/") + 1));
+        System.out.println("\t" + addTaskSalutation(input.substring(9, input.indexOf("/") - 1)));
+        user.listLength ++;
+        user.tasksIncomplete ++;
+        System.out.println("\tNow you have " + user.listLength + " tasks in the list, " + user.tasksIncomplete + " incomplete tasks");
+    }
+    public static void addEvent(String input, Tasks user) {
+        user.list[user.listLength] = new Event(input.substring(6, input.indexOf("/") - 1), input.substring(input.indexOf("/") + 1));
+        System.out.println("\t" + addTaskSalutation(input.substring(6, input.indexOf("/") - 1)));
+        user.listLength ++;
+        user.tasksIncomplete ++;
+        System.out.println("\tNow you have " + user.listLength + " tasks in the list, " + user.tasksIncomplete + " incomplete tasks");
+    }
+    public static void markDone(String input, Tasks user) {
+        int index = Integer.parseInt(input.substring(5)) - 1;
+        if (index < user.listLength) {
+            user.list[index].markComplete();
+            user.tasksIncomplete --;
+            System.out.println("\tAs you wish sir. I have marked this task as done:\n\t[X] " + user.list[index].item + "\n\tNow you have " + user.tasksIncomplete + " incomplete tasks");


Line length should be no longer than 120 chars.

teoziyiivy · 2021-09-03T06:45:43Z

src/main/java/Duke.java

+                "      @@.  %@,    @@   @@   #@(      @@&@.    #@*         @&\n" +
+                " */**.    */.      /*  **    ./*      */      ,*.  ,******  ";
+        greet(logo);
+        Tasks user = new Tasks();


A different variable name can be used to show tasks is a plural collection of the user's tasks.

teoziyiivy · 2021-09-03T06:47:45Z

src/main/java/Duke.java

+import java.util.Scanner;
+
 public class Duke {
+    public static String addTaskSalutation(String item) {


printTaskSalutation might be a better method name.

It would help to add comments for your method to clarify what it is doing.

teoziyiivy · 2021-09-03T06:48:15Z

src/main/java/Duke.java

+        System.out.println("\t____________________________________________________________\n");
+    }
+
+    public static void showList(Tasks user) {


printList might be a better method name.

kahhe

Code quality is quite well-adhered to. No deep nesting or methods with more than 30 LOC!

kahhe · 2021-09-03T06:59:36Z

src/main/java/Duke.java

+    public static void line() {
+        System.out.println("\t____________________________________________________________\n");
+    }


Consider naming as printLine() rather than line(). Methods' names should be verbs for easy understanding of their purposes.

kahhe · 2021-09-03T07:16:46Z

src/main/java/Task.java

@@ -0,0 +1,18 @@
+public class Task {
+    protected String item;
+    protected boolean complete;


Boolean variables should sound like a claim that can be true or false. isComplete may be more appropriate here.

…the user.

…ered by the user." This reverts commit b2ef7be.

…e user.

…changes. Load the data from the hard disk when Duke starts up.

* branch-Level-6: Add support for deleting tasks from the list.

* branch-Level-7: Save the tasks in the hard disk automatically whenever the task list changes. Load the data from the hard disk when Duke starts up. # Conflicts: # src/main/java/Duke.java

stephlewyh · 2021-09-19T08:12:06Z

src/main/java/Deadline.java

+public class Deadline extends Task{
+    protected String by;
+    protected String originalInput;
+    public Deadline(String description, String by, String originalInput) {


To improve code readability, you may wish to leave a line spacing the code block of class attributes and the constructor (Deadline()) here.

stephlewyh · 2021-09-19T08:14:17Z

src/main/java/Duke.java

+        Random rand = new Random();
+        String out = "";
+        switch(rand.nextInt(3)) {
+        case 0:


You are using integers for the switch cases. How about creating more meaningful names for each case?

stephlewyh · 2021-09-19T08:15:27Z

src/main/java/Duke.java

+import java.util.Scanner;
+
 public class Duke {
+    public static String addTaskSalutation(String item) {


It would help to add comments for your method to clarify what it is doing.

stephlewyh · 2021-09-19T08:18:06Z

src/main/java/Duke.java

+    }
+    public static void addTodo(String input, Tasks user) {
+        user.list[user.listLength] = new Todo(input.substring(5));
+        user.listLength ++;


The increment operator ++ is conventionally used without character spacing e.g.listLength++. You may wish to edit similar lines of code like this.

stephlewyh · 2021-09-19T08:21:03Z

src/main/java/Duke.java

+            System.out.println("\t" + (i + 1) + ". " + user.list[i] + "\n");
+        }
+    }
+    public static void addTodo(String input, Tasks user) {


You may wish to consider renaming the user parameter. It is strange that the parameter is user of type Tasks, when a task usually refers to object/item rather than a person.

stephlewyh · 2021-09-19T08:40:59Z

src/main/java/Duke.java

+        user.list[user.listLength] = new Deadline(input.substring(9, input.indexOf("/") - 1), input.substring(input.indexOf("/") + 1), input.substring(9));
+        user.listLength ++;
+        user.tasksIncomplete ++;


You have repeated uses of user.list[x] and other variables that keep track of the array position to fill. This makes the code slightly more complicated than necessary.

You could simplify the code further by doing without the array index (in this case listLength).
Try ArrayList so that you could add items to a growing list.

stephlewyh · 2021-09-19T08:45:06Z

src/main/java/Duke.java

+        }
+    }
+
+    public static void response(String input, Tasks user) throws IllegalCommandException, IllegalTaskException, DueDateFormatException, MultiMarkDoneException, IOException, DeleteTaskFormatException {


This method is rather long >30 LoC. How about abstracting out the procedures of each case into methods? Also see the SLAP principle.

stephlewyh · 2021-09-19T08:47:02Z

src/main/java/Duke.java

+    public static void response(String input, Tasks user) throws IllegalCommandException, IllegalTaskException, DueDateFormatException, MultiMarkDoneException, IOException, DeleteTaskFormatException {
+        String[] inputArr = input.split(" ");
+        switch (inputArr[0]) {
+        case ("list"):


The brackets () for each case are unnecessary - see switch statement style.

stephlewyh · 2021-09-19T08:49:50Z

src/main/java/Duke.java

+    private static void writeToFile(Tasks user) throws IOException {
+        FileWriter fw = new FileWriter(save);
+        for (int i = 0; i < user.listLength; i++) {
+            fw.write(user.list[i].getType() + " | " + user.list[i].getStatus() + " | " + user.list[i].getOriginalInput() +  System.lineSeparator());


This line is rather long, and could trip up the reader. The guideline is to have <120 chars per line.

Refer to the java string format() method example for another way to format long strings.

stephlewyh · 2021-09-19T08:52:40Z

src/main/java/Duke.java

+import java.nio.file.Files;
+import java.nio.file.Paths;
+
 public class Duke {


Generally, you could consider adding more comments to describe what your methods or classes are doing.

…the code to extract out closely related code as classes.

yapitsmejs added 7 commits August 23, 2021 01:13

Implement an initial skeletal version of the Duke that simply greets …

3d64ed6

…the user and exits.

Implement a skeletal version of Duke that starts by greeting the user…

daaef83

…, simply echos commands entered by the user, and exits when the user types bye.

Add the ability to store whatever text entered by the user and displa…

4014037

…y them back to the user when requested.

Add the ability to mark tasks as done.

a81bc62

Separate Task and Information classes

cd250ac

Add support for tracking three types of tasks. Change program persona…

aee5770

…lity. Add varying responses for adding tasks.

Correct spacing in response message. update ui-test input and expecte…

7bdb999

…d output

teoziyiivy reviewed Sep 3, 2021

View reviewed changes

kahhe reviewed Sep 3, 2021

View reviewed changes

yapitsmejs added 9 commits September 7, 2021 01:56

Teach Jarvis to deal with errors such as incorrect inputs entered by …

b2ef7be

…the user.

Revert "Teach Jarvis to deal with errors such as incorrect inputs ent…

d8af22f

…ered by the user." This reverts commit b2ef7be.

Teach Duke to deal with errors such as incorrect inputs entered by th…

b937e10

…e user.

Merge branch 'branch-Level-5'

b1afac4

Add support for deleting tasks from the list.

f083420

Save the tasks in the hard disk automatically whenever the task list …

3477bc0

…changes. Load the data from the hard disk when Duke starts up.

Merge branch 'branch-Level-6'

2aca76a

* branch-Level-6: Add support for deleting tasks from the list.

Merge branch 'branch-Level-7'

c729df8

* branch-Level-7: Save the tasks in the hard disk automatically whenever the task list changes. Load the data from the hard disk when Duke starts up. # Conflicts: # src/main/java/Duke.java

Resolved merge conflicts

e0aa491

stephlewyh reviewed Sep 19, 2021

View reviewed changes

yapitsmejs added 11 commits September 27, 2021 22:58

Give users a way to find a task by searching for a keyword. Refactor …

3a2629b

…the code to extract out closely related code as classes.

Merge branch 'branch-Level-9'

123b746

Add JavaDoc comments to the code.

6e3a937

Merge branch 'branch-A-JavaDoc'

d4638a8

Clean up Code. Fix bugs. Updated README.

4160b4a

Update README.

e4cb511

Update README

aae0f49

Update README

dc02a7c

Update README

c9c6b35

Update README

43757a3

Fixed bugs. Fixed coding standards.

685cadf

Conversation

yapjoonsiong commented Sep 1, 2021

Uh oh!

teoziyiivy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kahhe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants