iP by VishalJeyaram · Pull Request #188 · nus-cs2113-AY2122S1/ip

VishalJeyaram · 2021-09-01T08:03:38Z

Levels-0-3 and A-CodingStandard have been added

exits when the user types 'bye'.

…y them back to the user when requested

YEOWEIHNGWHYELAB

LGTM! There are minor code quality issues that can be fixed easily.

YEOWEIHNGWHYELAB · 2021-09-01T08:47:10Z

src/main/java/Duke.java

        Scanner in = new Scanner(System.in);
-        while ( byeFlag != 1 ) {
+        while (byeFlag != 1) {
            System.out.println("____________________________________________________________\n");


Suggestion:
Make a variable for printing underscore.

YEOWEIHNGWHYELAB · 2021-09-01T09:01:15Z

src/main/java/Duke.java

    // checkCommands() is a method that allows us to determine when the user says bye.
    private static void checkCommands(String line) {
-        if ( positionCheck >= 100 ) {
+        if (positionCheck >= 100) {


Suggestion:
Reduce the use of magic numbers.

YEOWEIHNGWHYELAB · 2021-09-01T09:01:33Z

src/main/java/Duke.java

-            if ( positionCheck == 0 ) {
+            if (positionCheck == 0) {
                System.out.println("There is no data to show master!");
            } else {


Suggestion:
Avoid deep nesting.

DmitriYam · 2021-09-03T03:39:12Z

src/main/java/Duke.java

+    private static Task[] commands = new Task[100];
+
+    // sendCommands() is a method used to allow the user to send his/her commands to C3PO
+    private static void sendCommands() {


could be changed to sayCommand as there is only 1 command

DmitriYam · 2021-09-03T03:40:01Z

src/main/java/Duke.java

+    }
+
+    // checkCommands() is a method that allows us to determine when the user says bye.
+    private static void checkCommands(String line) {


Similarly for this could be checkCommand

DmitriYam · 2021-09-03T03:42:34Z

src/main/java/Duke.java

+        sendCommands();
+        sayBye();
    }
 }


Overall, good naming conventions used 💯

DmitriYam · 2021-09-03T03:46:38Z

src/main/java/Duke.java

+                return;
+            }
+        }
+        System.out.println("Sorry Master! I don't think you have properly keyed in the parameters. Please enter the task, followed by \"/by\",\n" +


Could be split into 2 println statements to improve readability

YEOWEIHNGWHYELAB

LGTM! Just make some minor changes.

YEOWEIHNGWHYELAB · 2021-09-03T03:55:36Z

src/main/java/Duke.java

            }
+        } else if (line.equals("done")){
+            System.out.println("Oh no master, I am not quite sure which task you would like me to mark as done");
+        } else if (line.contains("done")){


Suggestion:
Could transfer these into another class.

YEOWEIHNGWHYELAB · 2021-09-03T03:56:09Z

src/main/java/Duke.java

@@ -31,11 +31,19 @@ private static void checkCommands(String line) {
            } else {


Suggestion: Avoid deep nesting.

YEOWEIHNGWHYELAB · 2021-09-03T03:56:32Z

src/main/java/Duke.java

+        String line;
+        Scanner in = new Scanner(System.in);
+        while ( byeFlag != 1 ) {
+            System.out.println("____________________________________________________________\n");


Suggestion:
Make a variable for printing underscore.

YEOWEIHNGWHYELAB · 2021-09-03T03:56:56Z

src/main/java/Duke.java

    // checkCommands() is a method that allows us to determine when the user says bye.
    private static void checkCommands(String line) {
-        if ( positionCheck >= 100 ) {
+        if (positionCheck >= 100) {


Suggestion:
Reduce the use of magic numbers.

YEOWEIHNGWHYELAB · 2021-09-03T03:58:03Z

src/main/java/Duke.java

+                "followed by the due date to specify the deadline Master!");
+    }
+
+    public static void addEvent(String[] input, int length) {


Try to use single level abstraction.

…e user

…changes

Branch a java doc

VishalJeyaram added 5 commits August 26, 2021 18:29

Level-0

0acc03a

echo commands entered by the user

e5a6c76

exits when the user types 'bye'.

Add the ability to store whatever text entered by the user and displa…

73e933e

…y them back to the user when requested

Added the ability to mark tasks as done.

9aa6701

Tweaked the code to comply with a coding standard

9d224de

YEOWEIHNGWHYELAB reviewed Sep 1, 2021

View reviewed changes

VishalJeyaram added 3 commits September 2, 2021 16:35

Added support for tracking three types of tasks

d10b249

Coding quality and standard improved

431e205

testing optimized

423e4b6

DmitriYam reviewed Sep 3, 2021

View reviewed changes

YEOWEIHNGWHYELAB reviewed Sep 3, 2021

View reviewed changes

VishalJeyaram added 19 commits September 9, 2021 17:31

Testing commit

dd62bad

fixing bugs

0fd82f9

Merge branch 'master' into testbranch

69645da

printing statements fixed

f2d4394

Line 118 printing formatting fixed

0a70a2e

Merge branch 'testbranch'

8235c1d

Work in progress level 5

199fc4c

Teach Duke to deal with errors such as incorrect inputs entered by th…

e893cef

…e user

Merge branch 'branch-Level-5'

f0a5864

Divide classes into packages

75c9f16

Merge branch 'branch-A-Packages'

f192e85

Add support for deleting tasks from the list.

b88ba29

Add support for deleting tasks from the list. (latest)

da1e49e

Save the tasks in the hard disk automatically whenever the task list …

23fdf30

…changes

Changed text file

4643e21

Level 7 commit

d87aae0

Adding the text file

9609e5f

Level 7 final commit

47dd64e

Added text file

95d1f4f

VishalJeyaram and others added 30 commits September 24, 2021 02:43

Added storage class halfway done

4561808

Ui and tasklist updated

a3b5c81

Task file updated

f16c13f

More OOP 90 percent implemented

99cffd9

More OOP done

55f4c5b

AJava Doc done

6310239

Bugs fixed and comments added

4e96b08

A Java Doc Done

5a77160

Text file changed

a1236a4

Merge branch 'master' into branch-A-JavaDoc

e6f1fd6

Merged Master and A-java doc

4f230f3

Merge pull request #3 from VishalJeyaram/branch-A-JavaDoc

56fdebc

Branch a java doc

Merge branch 'master' of https://github.com/VishalJeyaram/ip

a279691

More OOP completed

6022a07

Exception erros changed

d89f151

Class name changed and Ui messages updated

abf55fd

User Guide/README updated

553b120

Set theme jekyll-theme-hacker

9d2ea67

Updated Ui messages

7154720

Merge branch 'master' of https://github.com/VishalJeyaram/ip

effe27d

Command summary table updated

3b0adcf

Heading sizes updated for user guide

55bc19a

Hyperlinks for user guide updated

d2019f2

User guide sections separated

3bc240c

Final changes made. Code quality improved.

56bb844

Userguide final update

ffa2789

User guide final update

8cb4736

Update README.md

4466d03

Update README.md

b5a9282

Update README.md

b883ff9

		@@ -31,11 +31,19 @@ private static void checkCommands(String line) {
		} else {

Conversation

VishalJeyaram commented Sep 1, 2021

Uh oh!

YEOWEIHNGWHYELAB left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YEOWEIHNGWHYELAB left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants