[JonathanOngJoe] iP by Jonathan2745 · Pull Request #175 · nus-cs2113-AY2425S2/ip

Jonathan2745 · 2025-02-06T01:24:42Z

No description provided.

Li-JunXian

Great work overall, your code has a very clear logic chain. It feels very smooth reading it.

Li-JunXian · 2025-02-06T06:09:05Z

src/main/java/BobChat.java

+class Task {
+    private final String description;
+    private boolean isDone;
+
+    public Task(String description) {
+        this.description = description;
+        this.isDone = false;
+    }
+
+    public void markAsDone() {
+        isDone = true;
+    }
+
+    public void markAsNotDone() {
+        isDone = false;
+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "[X] " : "[ ] ") + description;
+    }
+}


Well coded! Simple and straight forward, maybe perhaps we can try creating a separate class file for "Task" so everything is not placed in one single java file.

Li-JunXian · 2025-02-06T06:15:43Z

src/main/java/BobChat.java

+    private int taskCount = 0;
+
+    public void start() {
+        System.out.println("____________________________________________________________");


Perhaps the horizontal lines can be assigned to a variable for easier reference and usage in the future as compared to inputting it every time.

Li-JunXian · 2025-02-06T06:21:27Z

src/main/java/BobChat.java

+                }
+                System.out.println("____________________________________________________________");
+            } else if (input.startsWith("mark ")) {
+                int index = Integer.parseInt(input.substring(5)) - 1;


I think it will be much more clearer to include comments on the meaning of "input.substring(5)) - 1" statement so that when looking back on the code in the future, everyone will understand the significance of the "- 1" for instance.

Li-JunXian · 2025-02-06T06:28:50Z

src/main/java/BobChat.java

+                    tasks[index].markAsNotDone();
+                    System.out.println("____________________________________________________________");
+                    System.out.println(" OK, I've marked this task as not done yet:");
+                    System.out.println("   " + tasks[index].getStatusIcon());


I think it is best not to start a System.out.printlin with a space or a tab, perhaps you can place the space and tab at the previous print statement's tail.

Li-JunXian · 2025-02-06T06:34:05Z

src/main/java/BobChat.java

+                System.out.println("____________________________________________________________");
+            } else if (input.startsWith("mark ")) {
+                int index = Integer.parseInt(input.substring(5)) - 1;
+                if (index >= 0 && index < taskCount) {


I think this line appears quite often, perhaps we could position this line with the higher-up if statement so that it can be checked earlier for the program to determine if it is a valid input or not and then execute the correct corresponding actions without doing any redundant work.

Deanson-Choo

Good Job Overall! A few touchups will do!

Deanson-Choo · 2025-02-06T07:15:44Z

src/main/java/BobChat.java

@@ -0,0 +1,97 @@
+import java.util.Scanner;
+
+class Task {


Maybe you can consider defining your classes such as Task in a separate file.

Deanson-Choo · 2025-02-06T07:30:08Z

src/main/java/BobChat.java

+        while (true) {
+            input = scanner.nextLine();
+
+            if (input.equalsIgnoreCase("bye")) {
+                break;
+            } else if (input.equalsIgnoreCase("list")) {
+                System.out.println("____________________________________________________________");
+                System.out.println(" Here are the tasks in your list:");
+                if (taskCount == 0) {
+                    System.out.println(" No tasks added yet.");
+                } else {
+                    for (int i = 0; i < taskCount; i++) {
+                        System.out.println((i + 1) + ". " + tasks[i].getStatusIcon());
+                    }
+                }
+                System.out.println("____________________________________________________________");
+            } else if (input.startsWith("mark ")) {
+                int index = Integer.parseInt(input.substring(5)) - 1;
+                if (index >= 0 && index < taskCount) {
+                    tasks[index].markAsDone();
+                    System.out.println("____________________________________________________________");
+                    System.out.println(" Nice! I've marked this task as done:");
+                    System.out.println("   " + tasks[index].getStatusIcon());
+                    System.out.println("____________________________________________________________");
+                }
+            } else if (input.startsWith("unmark ")) {
+                int index = Integer.parseInt(input.substring(7)) - 1;
+                if (index >= 0 && index < taskCount) {
+                    tasks[index].markAsNotDone();
+                    System.out.println("____________________________________________________________");
+                    System.out.println(" OK, I've marked this task as not done yet:");
+                    System.out.println("   " + tasks[index].getStatusIcon());
+                    System.out.println("____________________________________________________________");
+                }
+            } else {
+                if (taskCount < 100) {
+                    tasks[taskCount++] = new Task(input);
+                    System.out.println("____________________________________________________________");
+                    System.out.println(" added: " + input);
+                    System.out.println("____________________________________________________________");
+                } else {
+                    System.out.println(" Task list is full!");
+                }
+            }
+        }


Perhaps you can consider adding another class to manage your tasks to neaten the code

Deanson-Choo · 2025-02-06T07:34:18Z

src/main/java/BobChat.java

+    public void markAsDone() {
+        isDone = true;
+    }
+
+    public void markAsNotDone() {
+        isDone = false;
+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "[X] " : "[ ] ") + description;
+    }
+}


Perhaps you can consider combining markAsNotDone and markAsDone under a single function such as setStatus. Also, should there be a getter function for description and isDone?

Deanson-Choo · 2025-02-06T07:35:44Z

src/main/java/BobChat.java

+    private int taskCount = 0;
+
+    public void start() {
+        System.out.println("____________________________________________________________");


Perhaps considering assigning the horizontal line to a variable for easier usage

Deanson-Choo · 2025-02-06T07:40:03Z

src/main/java/BobChat.java

+        while (true) {
+            input = scanner.nextLine();
+
+            if (input.equalsIgnoreCase("bye")) {
+                break;
+            } else if (input.equalsIgnoreCase("list")) {
+                System.out.println("____________________________________________________________");
+                System.out.println(" Here are the tasks in your list:");
+                if (taskCount == 0) {
+                    System.out.println(" No tasks added yet.");
+                } else {
+                    for (int i = 0; i < taskCount; i++) {
+                        System.out.println((i + 1) + ". " + tasks[i].getStatusIcon());
+                    }
+                }
+                System.out.println("____________________________________________________________");
+            } else if (input.startsWith("mark ")) {
+                int index = Integer.parseInt(input.substring(5)) - 1;
+                if (index >= 0 && index < taskCount) {
+                    tasks[index].markAsDone();
+                    System.out.println("____________________________________________________________");
+                    System.out.println(" Nice! I've marked this task as done:");
+                    System.out.println("   " + tasks[index].getStatusIcon());
+                    System.out.println("____________________________________________________________");
+                }
+            } else if (input.startsWith("unmark ")) {
+                int index = Integer.parseInt(input.substring(7)) - 1;
+                if (index >= 0 && index < taskCount) {
+                    tasks[index].markAsNotDone();
+                    System.out.println("____________________________________________________________");
+                    System.out.println(" OK, I've marked this task as not done yet:");
+                    System.out.println("   " + tasks[index].getStatusIcon());
+                    System.out.println("____________________________________________________________");
+                }
+            } else {
+                if (taskCount < 100) {
+                    tasks[taskCount++] = new Task(input);
+                    System.out.println("____________________________________________________________");
+                    System.out.println(" added: " + input);
+                    System.out.println("____________________________________________________________");
+                } else {
+                    System.out.println(" Task list is full!");
+                }
+            }
+        }


Perhaps you can consider adding comments to each of your conditions too!

…on of ASCIIArt (BobCHungus)

aditichadha1310

overall, good work!

aditichadha1310 · 2025-02-27T07:17:34Z

src/main/java/BobChat.java

+            try {
+                switch (command) {
+                    case "bye":
+                        System.out.println("____________________________________________________________");


Since this line of code is repeating at multiple instances, you might want to save it in a variable or make it a function which you can reference.

aditichadha1310 · 2025-02-27T07:18:01Z

src/main/java/BobChat.java

+    private final Scanner scanner = new Scanner(System.in);
+    private final ArrayList<Task> tasks = new ArrayList<>();
+
+    public void start() throws InputExceptions {


Avoid lengthy methods. try to keep each method to about 30 lines of code.

Branch level 7

Merging A-Assertions

Merge A-Code-Quality

Branch level 9 + Java Docs

A-UserGuide

editted A-UserGuide

Branch level 9

minor changes to JavaDoc

HYCGreenBU added 6 commits February 6, 2025 08:18

Level-0

48f39eb

Level-1

ab993ab

Level-1

07a7b0c

Level 2

f7d1a76

Level-2

831d116

Level-3

a1511a8

Li-JunXian reviewed Feb 6, 2025

View reviewed changes

Deanson-Choo reviewed Feb 6, 2025

View reviewed changes

Jonathan2745 added 5 commits February 7, 2025 12:23

Level-4 + code abstraction of Todo, Task, Deadline and Event + Additi…

57d2187

…on of ASCIIArt (BobCHungus)

added .runtest.bat file for testing

6c70014

Level-5

2cb933b

added ArrayList<Task> and Level-5

b55d25c

Level-7

a19da34

aditichadha1310 reviewed Feb 27, 2025

View reviewed changes

Jonathan2745 and others added 16 commits March 5, 2025 20:36

removed user data from git push

17f8b69

added classes - not implemented yet

f7e39c3

7.1

0a8bc50

Merge pull request #1 from Jonathan2745/branch-Level-7

04e26d7

Branch level 7

A-Assertions

c5ef628

A-CodeQuality

5c4b5e5

Merge pull request #2 from Jonathan2745/branch-A-Assertions

e16dc6e

Merging A-Assertions

Merge branch 'master' into branch-A-CodeQuality

0b70080

Merge pull request #3 from Jonathan2745/branch-A-CodeQuality

95e0b5a

Merge A-Code-Quality

added level-8

c17a112

Level-9

6cf9f40

Added A-JavaDoc

ff5d6c7

Merge pull request #4 from Jonathan2745/branch-Level-9

922a9b2

Branch level 9 + Java Docs

A-UserGuide

7f7c47d

Merge pull request #5 from Jonathan2745/branch-Level-9

66f2146

A-UserGuide

editted A-UserGuide

ad1e2a1

Jonathan2745 and others added 14 commits March 12, 2025 14:37

Merge pull request #6 from Jonathan2745/branch-Level-9

aa75453

editted A-UserGuide

added minor bug fixing, file creation and error responses

6130536

Merge branch 'master' into branch-Level-9

65a5c5d

Merge pull request #7 from Jonathan2745/branch-Level-9

635922b

Branch level 9

added bug fix for missing data folder

d0d692d

ascii art bug

34dc388

ascii art bug

48bb30c

ascii art bug

2161a47

edittde user guide

3d376b2

testing userguide

04640b1

testing userguide

649909e

testing userguide

e417e4b

minor changes to JavaDoc

552f814

Merge pull request #8 from Jonathan2745/branch-A-JavaDoc

6ab34c8

minor changes to JavaDoc

Conversation

Jonathan2745 commented Feb 6, 2025

Uh oh!

Li-JunXian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Deanson-Choo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aditichadha1310 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants