[paklongchiu] iP by paklongchiu · Pull Request #192 · nus-cs2113-AY2425S2/ip

paklongchiu · 2025-02-07T05:30:07Z

No description provided.

This reverts commit a8435c7.

This reverts commit 1f4bfd9.

…sted

…o do so

…oding standard

Ashertan256

Overall, the structure and flow of the code seems a little redundant at certain parts. But the format looks to be consistent with the course!

Ashertan256 · 2025-02-07T17:00:24Z

src/main/java/Elyk.java

+    public static void main(String[] args) {
+        greet();
+
+        while (true) {


Instead of while(true), maybe you can consider using this instead:

do {
// code to run
}
while (!input.equal("bye"));

Ashertan256 · 2025-02-07T17:23:52Z

src/main/java/Elyk.java

+    public static void markTaskNotDone(int taskNum) {
+        taskList[taskNum - 1].markAsNotDone();
+        System.out.println("OK, I've marked this task as not done yet:");
+        System.out.println("  [ ] " + taskList[taskNum - 1].description);


Would using taskList[i].getStatusIcon (as you used below) be more consistent?

Ashertan256 · 2025-02-07T17:28:35Z

src/main/java/Elyk.java

+
+    public static void updateInput() {
+        input = command.nextLine();
+        if (input.matches(".*\\d$")) {


A comment could be added to describe the regex pattern to be clearer

Ashertan256 · 2025-02-07T17:36:28Z

src/main/java/Elyk.java

+        if (input.matches(".*\\d$")) {
+            String[] words = input.split(" ");
+            input = words[0];
+            taskNum = Integer.parseInt(words[1]);


This could potentially have issues if the second word is not a number. Attempting to parseInt a String may crash the program/cause an exception

Ashertan256 · 2025-02-07T17:41:45Z

src/main/java/Elyk.java

+    }
+
+    public static void markTaskNotDone(int taskNum) {
+        taskList[taskNum - 1].markAsNotDone();


This seems like a redundant method, is it possible to call a single method without chaining multiple methods that do the same thing?

…e and Event

like input task type is not supported or there is missing information from the input

thomasjlalba

Good job thus far! Just some trivial suggestions to make it more readable and understandable for others.

thomasjlalba · 2025-02-20T08:55:12Z

src/main/java/Elyk.java

+            to = input.substring(toPos + 4);
+            from = input.substring(fromPos + 6, toPos - 1);
+            description = input.substring(6, fromPos - 1);


Maybe you can refactor the magic literals throughout your code to make it easier to understand

thomasjlalba · 2025-02-20T08:59:10Z

src/main/java/Elyk.java

+            from = input.substring(fromPos + 6, toPos - 1);
+            description = input.substring(6, fromPos - 1);
+            input = "event";
+        }


Maybe you can include the final else statement for error detection

thomasjlalba · 2025-02-20T09:07:48Z

src/main/java/Elyk.java

+    public static void printTask() {
+        System.out.println("Here are the tasks in your list:");
+        for (int i = 0; i < taskCounter; i++) {
+            System.out.println((i+1) + "." + taskList[i]);


Maybe you can standardise the use of spacing within your i+1 to make it more consistent (i + 1 instead)

thomasjlalba · 2025-02-20T09:10:06Z

src/main/java/Elyk.java

+                    markTaskNotDone(taskNum);
+                    break;
+                case "todo":
+                    taskList[taskCounter++] = new Todo(description);


It might be more readable by separating the increment to the next line instead of combining it in the same line

thomasjlalba · 2025-02-20T09:11:56Z

src/main/java/Elyk.java

+    public static int taskCounter = 0;
+    public static int taskNum = 0;


The naming of these variables might suggest that they are the same. Maybe you can consider renaming them to make them clearer and more distinct.

thomasjlalba · 2025-02-20T09:13:50Z

src/main/java/Elyk.java

+    public static Scanner command = new Scanner(System.in);
+
+    public static void main(String[] args) {
+        greet();


Good job on the abstraction of code to make it neater!

…ask into an abstract class

…st()

…a file

…ment of local variable

…ving function

… created Ui and Parser class Modified code in Elyk and Storage to use TaskList instead

… in Elyk to work with them

…cording to keyword

… methods

Branch level 9

# Conflicts: # src/main/java/Ui.java

Branch a java doc

Thomas Chiu added 7 commits January 31, 2025 15:48

Level-0

a8435c7

Revert "Level-0"

1f4bfd9

This reverts commit a8435c7.

Reapply "Level-0"

0144f1c

This reverts commit 1f4bfd9.

Enable ability to echo user's input, exit when it is bye

e3bd341

Enable the ability to store user's inputs and display them when reque…

7ce0ae2

…sted

Add functions to mark and unmark tasks, while adopting a Task class t…

0643a10

…o do so

Optimise the way of getting input and check if the code aligns with c…

9ac4899

…oding standard

Ashertan256 reviewed Feb 7, 2025

View reviewed changes

Thomas Chiu added 2 commits February 14, 2025 12:28

Using inheritance to support tracking 3 types of tasks: Todo, Deadlin…

dd8334e

…e and Event

Added some exceptions for dealing with errors,

cb07f89

like input task type is not supported or there is missing information from the input

thomasjlalba reviewed Feb 20, 2025

View reviewed changes

Thomas Chiu and others added 19 commits February 21, 2025 12:33

Using ArrayList<Task> instead of an array to store tasks and turned T…

6771044

…ask into an abstract class

Enabled deleting tasks from the list by task index

1eea51f

Replaced taskCounter with taskList.size() and utilised taskList.getLa…

02b0f40

…st()

Created a new class Storage to deal with loading and saving tasks in …

4f3ad6c

…a file

Made amendments in parseTaskFromString() so that there is no reassign…

9be6807

…ment of local variable

Merge branch 'branch-Level-6'

9902379

Merge branch 'branch-Level-7'

217a2dd

Added loadTasks() and saveTasks() into main() to complete the task sa…

5d4692d

…ving function

Fixed the issue of displaying wrong no. of tasks in deleteTask()

bd41e9f

Implemented a new class TaskList to contain the task list in Elyk and…

a8c554c

… created Ui and Parser class Modified code in Elyk and Storage to use TaskList instead

Implemented class Ui but yet to incorporate its methods in other classes

934cd37

Completed implementing all new classes for OOP and modified the logic…

27f12a9

… in Elyk to work with them

Added "find" command case and method to extract keyword in Parser class

ef12c47

Updated Ui and TaskList classes to find and display matching tasks ac…

bc5e903

…cording to keyword

Updated main logic in Elyk to support finding tasks by a keyword

21a639f

Added JavaDoc comments to the Ui class and all of its methods

3dc8f6a

Added JavaDoc comments to 3 more classes and all of their non-private…

f5a0f9d

… methods

Completed the remaining JavaDoc comments for all classes and methods

03f4d46

Merge pull request #1 from paklongchiu/branch-Level-9

071a94a

Branch level 9

Thomas Chiu and others added 3 commits March 14, 2025 21:54

Merge branch 'master' into branch-A-JavaDoc

620b83e

# Conflicts: # src/main/java/Ui.java

Merge pull request #2 from paklongchiu/branch-A-JavaDoc

1c329ea

Branch a java doc

Explained the 9 main features of Elyk in UG

9cc84c0

		public static int taskCounter = 0;
		public static int taskNum = 0;

Conversation

paklongchiu commented Feb 7, 2025

Uh oh!

Ashertan256 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thomasjlalba left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants