Open
Conversation
telferang
reviewed
Feb 18, 2025
telferang
left a comment
telferang
left a comment
There was a problem hiding this comment.
Consider separating the code into different files.
src/main/java/Eddie.java
Outdated
| /** | ||
| * Marks the task as done. | ||
| */ | ||
| public void markDone() {this.isDone = true;} |
There was a problem hiding this comment.
Consider not having the whole function in a single line to following the coding standard.
src/main/java/Eddie.java
Outdated
| * @throws EddieException If the format is incorrect. | ||
| */ | ||
| private void addDeadLine(String details) throws EddieException { | ||
| EddieException.checkDeadline(details); |
There was a problem hiding this comment.
Consider extracting the checking function to another class.
src/main/java/Eddie.java
Outdated
Comment on lines
+124
to
+130
| int index = EddieException.checkTaskStatus(taskIndex, taskCount); | ||
| if (markDone) { | ||
| tasks[index].markDone(); | ||
| } else { | ||
| tasks[index].markNotDone(); | ||
| } | ||
| Display.showMarkedStatus(tasks[index], markDone); |
There was a problem hiding this comment.
Basic indentation should be 4 spaces.
added theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.