Open
Conversation
src/main/java/Wen.java
Outdated
| public class Wen { | ||
|
|
||
| private static int taskCount = 0; | ||
| private static Task[] tasks = new Task[100]; |
There was a problem hiding this comment.
avoid using magic numbers, declare 100 as a constant like TASKS_SIZE
src/main/java/Wen.java
Outdated
| default: | ||
| System.out.println(command); | ||
| addTask(input); | ||
| // System.out.println("Unknown command \""+command+"\"! Double check your message and try running again~"); |
There was a problem hiding this comment.
Delete the codes that are commented and not used.
src/main/java/Wen.java
Outdated
| final String command = input.split(" ", 2)[0]; | ||
| final String commandArgs = input.split(" ", 2).length > 1 ? input.split(" ", 2)[1] : ""; | ||
|
|
||
| switch (command) { |
There was a problem hiding this comment.
There should be no indentation for case clauses, refer to the Java Coding standard.
src/main/java/Wen.java
Outdated
|
|
||
| while (!command.equals("bye")) { | ||
| command = in.nextLine(); | ||
| while (!input.equals("bye")) { |
There was a problem hiding this comment.
The nested loop is not correctly indented, and consider whether you need the outer loop or not.
added javadoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.