Open
Conversation
telferang
reviewed
Mar 7, 2025
src/main/java/Event.java
Outdated
Comment on lines
+3
to
+8
| protected String time1; | ||
| protected String time2; | ||
| public Event(String description, String time1, String time2){ | ||
| super(description); | ||
| this.time1 = time1; | ||
| this.time2 = time2; |
There was a problem hiding this comment.
Consider using a more descriptive name such as startTime, endTime instead of time1 and time2.
src/main/java/Rick.java
Outdated
| What can I do for you? | ||
| """); | ||
| Scanner s = new Scanner(System.in); | ||
| Task[] tasks = new Task[100]; //create an Task array called tasks that hold 100 Task elements; |
There was a problem hiding this comment.
Consider using a constant to avoid magic numbers
src/main/java/Rick.java
Outdated
Comment on lines
+87
to
+90
| try{ | ||
| if(input.isEmpty()){ | ||
| throw new RickException(); | ||
| }}catch(RickException e){ |
There was a problem hiding this comment.
Suggested change
| try{ | |
| if(input.isEmpty()){ | |
| throw new RickException(); | |
| }}catch(RickException e){ | |
| try { | |
| if (input.isEmpty()) { | |
| throw new RickException(); | |
| } | |
| } catch (RickException e) { |
Consider following the coding standard as shown above to maintain consistency and readability throughout your code.
src/main/java/Rick.java
Outdated
Comment on lines
+106
to
+107
| String Deadline_description = part[0].trim(); | ||
| String Deadline_date = part[1].trim(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.