Open
Conversation
added 6 commits
February 21, 2025 17:13
…s, alternative goodbyes)
…ain, annoyance temporarily disabled)
Hackin7
reviewed
Mar 5, 2025
Hackin7
left a comment
Hackin7
left a comment
There was a problem hiding this comment.
Good attempt at commenting but comments are generally self explanatory, can remove some redundant ones. Other than that generally reducing arrowhead code helps
| int taskCount = 0; | ||
|
|
||
| // main program loop - continues until user types bye | ||
| do { |
There was a problem hiding this comment.
arrowhead code, can try to do more abstraction etc.
| String message = DIVIDER + NEWLINE + "added: " + task.description + NEWLINE + DIVIDER; | ||
| System.out.println(message); | ||
|
|
||
| // return updated task count |
There was a problem hiding this comment.
This comment is redundant
A few comments are good, but some are also redundant so do take note
| "WHY ARE YOU STILL HERE? TYPE 'BYE' TO EXIT!", | ||
| "I CANT KEEP DOING THIS! PLEASE TYPE BYE!!!", | ||
| "RELEASE ME FROM MY PRISON!!!", | ||
| "I EXIST ONLY TO SUFFER", |
| } else { | ||
| goodbye = DIVIDER + NEWLINE | ||
| + "Bye. Hope to see you again soon!" + NEWLINE | ||
| + "Oongaliegabangalie is always watching..." + NEWLINE |
There was a problem hiding this comment.
Should you try to use the BOT_NAME variable here instead of hard coding it into the string?
…e exception wasnt being thrown correctly)
…tead of static Arrays)
…g old static array system and without delete function to practice parallel branches and merge conflict resolution)
* branch-Level-6: Level-6 (Implemented delete function, switched to using ArrayList instead of static Arrays)
* branch-Level-7: Level-7 (implemented save function with un-updated master branch using old static array system and without delete function to practice parallel branches and merge conflict resolution) # Conflicts: # src/main/java/oongaliegabangalieBot/ui/oongaliegabangalie.java
…evel-6 and Level-7 implemented
Branch level 8
Level-9 (Find function)
A-JavaDoc (Added comments)
* 'master' of https://github.com/OliverQiL/ip: A-JavaDoc (Added comments) Level-9 (Find function) Level-8 (Added dates and times functionality for BOTH deadline and event commands) * 'master' of https://github.com/OliverQiL/ip: A-JavaDoc (Added comments) Level-9 (Find function) Level-8 (Added dates and times functionality for BOTH deadline and event commands)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.