feat(core): split Extend into CoverLanding vs Span#1113
Open
kronberger-droid wants to merge 2 commits into
Open
feat(core): split Extend into CoverLanding vs Span#1113kronberger-droid wants to merge 2 commits into
kronberger-droid wants to merge 2 commits into
Conversation
- SelectionExtent axis chosen per edit mode (vi -> CoverLanding, bar modes -> Span); orthogonal to CaretGeometry - Cursor::extend_span grows a Span without vi-visual widening, sharing flip_anchor (extracted from put_cursor) on reversal - funnel both placement strategies through Editor::place
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SelectionExtent(CoverLanding | Span): per-mode selection-model axis, orthogonal toCaretGeometry.EditCommand::Extendbranches on it:put_cursor)extend_span).Cursor::extend_span: grows a Span to gap-indexedop_end, no vi-visual wideningEditor::place(set_cursor+commit_cursor).Why
Tests
extend_spanunits incl. the Helix-bound block-reversal flip.Extend(w)grows the Span.Notes
pub(crate)).fmt+clippy --all-targetsclean; full suite green.