Calculate Expander Zone Numbers Correctly for SE Panels #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determine if is an SE panel by the address of the device which is always 31 for SE panels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my simple solution for SE Panels. It uses the device address to determine if the panel is an SE version. Since all SE devices have to be set to address 31. However, if a user with a normal Ademco device was using address 31, this would cause an issue. I don't know how often that happens, it looks like the default recommended address is 18, so a long way off.
Anyways, this is my fix for #61.
The right answer is probably to fix the underlying configuration in the Alarm Decoder code (not sure where the repository for that is) so that SE devices perhaps are reported as mode=S or something.