feat(FormField): add required field support across form components
#4687
Conversation
rdjanuar
changed the title
required field support across form components
|
sorry i make pull request again because i`m accidently remove my repository @benjamincanac |
commit: |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
) Co-authored-by: Sandro Circi <[email protected]>
Co-authored-by: Benjamin Canac <[email protected]>
benjamincanac
force-pushed
the
v3
branch
2 times, most recently
from
a3fc9ca to
13eecb1
Compare
|
@rdjanuar Would you be willing to move this PR to v4? |
| return { | ||
| [props.orientation === 'vertical' ? 'height' : 'width']: percent.value ? `${percent.value}%` : 'fit-content' | ||
| } | ||
| const value = `${Math.max(percent.value ?? 0, 0)}%` |
There was a problem hiding this comment.
Hi! I was looking at this PR as it seems to have gotten stuck, and I wanted to gently suggest a couple of things that might help the maintainers handle it more easily.
-
Unrelated Changes ("Code Churn"): This change, for example, doesn't seem to be related to the PR's main goal. I've also noticed other similar changes throughout the files, like updates to CSS. To make the core change clearer, it would be helpful if these unrelated changes could be moved to a separate PR (like "Simplify code").
-
There are currently 33 commits in this PR. For a focused change like this, it would be better if they could be rebased and squashed down into a single commit.
No offense — I was actually going to come up with a similar request, and now I see there's even a ready made PR, and to be honest I understand why it is.
|
@benjamincanac I struggle with package json EOL and pnpm.lock, would you mind to help me ? |
7 participants
🔗 Linked issue
Resolves #4529
❓ Type of change
📚 Description
📝 Checklist