Skip to content

Commit

Permalink
resolve rapids-dependency-file-generator warning (#482)
Browse files Browse the repository at this point in the history
Contributes to rapidsai/dependency-file-generator#89.

`--file_key` has been deprecated in `rapids-dependency-file-generator` for a few months, and I'm looking to fully remove it.

This PR proposes:

* switching this project's uses from `--file_key` to `--file-key`
* updating the version of `rapids-dependency-file-generator` used in `pre-commit` to its latest release
* switching from `mamba env create --force` to `mamba env create --yes`

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Christopher Harris (https://github.com/cwharris)

URL: #482
  • Loading branch information
jameslamb committed Jun 17, 2024
1 parent 7b599a3 commit 439d7df
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

repos:
- repo: https://github.com/rapidsai/dependency-file-generator
rev: v1.7.1
rev: v1.13.11
hooks:
- id: rapids-dependency-file-generator
args: ["--clean"]
Expand Down
4 changes: 2 additions & 2 deletions ci/check_style.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ rapids-logger "Create checks conda environment"

rapids-dependency-file-generator \
--output conda \
--file_key checks \
--file-key checks \
--matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION}" | tee env.yaml

rapids-mamba-retry env create --force -f env.yaml -n checks
rapids-mamba-retry env create --yes -f env.yaml -n checks
conda activate checks

# Run pre-commit checks
Expand Down

0 comments on commit 439d7df

Please sign in to comment.