Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert partially constructed segments on-error in segment init function #407

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 12, 2023

Description

  • All nodes and edge holders now can optionally be assigned a name for ease of debugging.
  • Explicitly release edges from ingress/egress ports and manifolds.
  • Ensure that the inner_edge held by the ForwardingEgressProvider is disconnected.

Fixes #360
Fixes #400
Fixes #401

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

…s different builds of llvm packages to fix CI
…nts check_active_connection from mistakenly returning true for a holder where init_owned_edge has been called but neither the init_connected_edge method or the add_connector method have not been called
@dagardner-nv dagardner-nv requested review from a team as code owners October 12, 2023 23:21
@dagardner-nv dagardner-nv self-assigned this Oct 12, 2023
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Oct 12, 2023
@dagardner-nv dagardner-nv changed the title Revert partially constructed segments on-error in segment init function Draft: Revert partially constructed segments on-error in segment init function Oct 12, 2023
@dagardner-nv dagardner-nv changed the title Draft: Revert partially constructed segments on-error in segment init function Revert partially constructed segments on-error in segment init function Oct 13, 2023
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Merging #407 (4636694) into branch-23.11 (de48cb1) will decrease coverage by 0.20%.
The diff coverage is 85.45%.

❗ Current head 4636694 differs from pull request most recent head 67840a2. Consider uploading reports for the commit 67840a2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #407      +/-   ##
================================================
- Coverage         74.03%   73.84%   -0.20%     
================================================
  Files               394      385       -9     
  Lines             13955    13710     -245     
  Branches           1053     1033      -20     
================================================
- Hits              10332    10124     -208     
+ Misses             3623     3586      -37     
Flag Coverage Δ
cpp 69.84% <75.46%> (-0.68%) ⬇️
py 43.29% <81.52%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cpp/mrc/include/mrc/edge/edge_builder.hpp 86.53% <100.00%> (+4.13%) ⬆️
...pp/mrc/include/mrc/manifold/composite_manifold.hpp 88.88% <100.00%> (+2.22%) ⬆️
cpp/mrc/include/mrc/manifold/interface.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/node/generic_sink.hpp 63.63% <100.00%> (-3.04%) ⬇️
cpp/mrc/include/mrc/node/generic_source.hpp 60.00% <100.00%> (+7.05%) ⬆️
cpp/mrc/include/mrc/node/queue.hpp 100.00% <100.00%> (ø)
cpp/mrc/include/mrc/node/rx_sink.hpp 97.77% <100.00%> (+0.15%) ⬆️
cpp/mrc/include/mrc/node/rx_sink_base.hpp 100.00% <100.00%> (ø)
cpp/mrc/include/mrc/node/rx_source.hpp 94.73% <100.00%> (+0.98%) ⬆️
cpp/mrc/include/mrc/node/rx_source_base.hpp 83.33% <100.00%> (+10.60%) ⬆️
... and 20 more

... and 70 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de48cb1...67840a2. Read the comment docs.

@dagardner-nv dagardner-nv marked this pull request as draft January 19, 2024 17:24
@dagardner-nv dagardner-nv changed the base branch from branch-23.11 to branch-24.03 January 19, 2024 17:31
@dagardner-nv
Copy link
Contributor Author

Closing in favor of #434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
1 participant