Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert partially constructed segments on-error in segment init function #407

Closed
wants to merge 85 commits into from
Closed

Revert partially constructed segments on-error in segment init function #407

wants to merge 85 commits into from

Commits on Aug 2, 2023

  1. Don't skip this test as its perfectly valid and passes, the reference… 

    …d issue isn't relevent to this test
    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ef06972 View commit details
    Browse the repository at this point in the history

  2. Test for issue nv-morpheus#360

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    79d144b View commit details
    Browse the repository at this point in the history

  3. Remove unneeded copy/paste code

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    52968bf View commit details
    Browse the repository at this point in the history

  4. Revert added objects and ingress/egress ports on error in segment ini… 

    …t function
    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1178c02 View commit details
    Browse the repository at this point in the history

  5. Better test name

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ac2853c View commit details
    Browse the repository at this point in the history

  6. wip

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6a26e4f View commit details
    Browse the repository at this point in the history

  7. Only run iwyu on compilation units actually changed in PR

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    cccef95 View commit details
    Browse the repository at this point in the history

  8. Checks require clang

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6914da7 View commit details
    Browse the repository at this point in the history

  9. Revert "Checks require clang" 

    This reverts commit 6914da7.
    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    dbeeedc View commit details
    Browse the repository at this point in the history

  10. test [no ci]

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    faf233c View commit details
    Browse the repository at this point in the history

  11. Don't fetch base branch if it's already set

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9fa907c View commit details
    Browse the repository at this point in the history

  12. Add comment explaining version

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    81d094f View commit details
    Browse the repository at this point in the history

  13. Avoid 15.0.7

    @dagardner-nv
    dagardner-nv committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9d55259 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. revert clang version changes [no ci]

    @dagardner-nv
    dagardner-nv committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    1eb89f7 View commit details
    Browse the repository at this point in the history

  2. Adopt updated versions of boost and libhwlock this <hand wavy> choose… 

    …s different builds of llvm packages to fix CI
    @dagardner-nv
    dagardner-nv committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c0f8a35 View commit details
    Browse the repository at this point in the history

  3. Apply fix from mdemoret-nv:mdd_force-stubgen-dev

    @dagardner-nv
    dagardner-nv committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    46ac7b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Merge branch 'branch-23.11' of github.com:nv-morpheus/MRC into david-… 

    …inconsistent-pipe
    @dagardner-nv
    dagardner-nv committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    a6244c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Merge branch 'branch-23.11' into david-inconsistent-pipe [no ci]

    @dagardner-nv
    dagardner-nv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f285c41 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-23.11' into david-inconsistent-pipe

    @dagardner-nv
    dagardner-nv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f6503db View commit details
    Browse the repository at this point in the history

  3. Merge branch 'david-inconsistent-pipe' of github.com:dagardner-nv/MRC… 

    … into david-inconsistent-pipe
    @dagardner-nv
    dagardner-nv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0f1bf1c View commit details
    Browse the repository at this point in the history

  4. IWYU changes

    @dagardner-nv
    dagardner-nv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1cd28f6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'branch-23.11' of github.com:nv-morpheus/MRC into david-… 

    …inconsistent-pipe
    @dagardner-nv
    dagardner-nv committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    743d4d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Python repro for issue nv-morpheus#360

    @dagardner-nv
    dagardner-nv committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    dfa066e View commit details
    Browse the repository at this point in the history

  2. Place executor.join under exception handler [no ci]

    @dagardner-nv
    dagardner-nv committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9e9a5f7 View commit details
    Browse the repository at this point in the history

  3. Fix repro test, works if segment2 raises, but fails os segment1 raise… 

    …s [no ci]
    @dagardner-nv
    dagardner-nv committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    38c0e15 View commit details
    Browse the repository at this point in the history

  4. Add second test, with exception being thrown in both the first and se… 

    …cond segments [no ci]
    @dagardner-nv
    dagardner-nv committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    22220a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Test edgeholder connections

    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    39ba316 View commit details
    Browse the repository at this point in the history

  2. release_edge_connection should only reset the m_connected_edge, preve… 

    …nts check_active_connection from mistakenly returning true for a holder where init_owned_edge has been called but neither the init_connected_edge method or the add_connector method have not been called
    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    790a50c View commit details
    Browse the repository at this point in the history

  3. IWYU fixes

    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    50b50e7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'test-edge-holder' into david-inconsistent-segments-and-… 

    …edges
    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6d5ec3a View commit details
    Browse the repository at this point in the history

  5. Fix type-o

    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8e90892 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'test-edge-holder' into david-inconsistent-segments-and-… 

    …edges
    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a5e27a5 View commit details
    Browse the repository at this point in the history

  7. WIP: A bunch of bebug logging that needs to be removed, add a destroy… 

    … method to ObjectProperties [no ci]
    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    987d8f1 View commit details
    Browse the repository at this point in the history

  8. pare back unneeded changes

    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3c77dcc View commit details
    Browse the repository at this point in the history

  9. Stop all segments in the pipeline

    @dagardner-nv
    dagardner-nv committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0542cb2 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Remove unneeded hack

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    765e8ae View commit details
    Browse the repository at this point in the history

  2. Shutdown manifolds

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    502b8cc View commit details
    Browse the repository at this point in the history

  3. Better handling for manifolds

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2df03d7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-23.11' of github.com:nv-morpheus/MRC into david-… 

    …inconsistent-segments-and-edges
    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3f12bac View commit details
    Browse the repository at this point in the history

  5. Prevent pipeline shutdown from occurring in multiple threads

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fa680bf View commit details
    Browse the repository at this point in the history

  6. Use a fiber mutex

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    587ad7f View commit details
    Browse the repository at this point in the history

  7. More logs

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b18dac6 View commit details
    Browse the repository at this point in the history

  8. Shutdown ingress and egress ports

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3c7c574 View commit details
    Browse the repository at this point in the history

  9. Revert mistaken change

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    efa9022 View commit details
    Browse the repository at this point in the history

  10. Cleanup logging

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3e20b24 View commit details
    Browse the repository at this point in the history

  11. Revert accidental changes

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    d3f5a21 View commit details
    Browse the repository at this point in the history

  12. Cleanup logging

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9565284 View commit details
    Browse the repository at this point in the history

  13. Call do_service_kill from shutdown

    @dagardner-nv
    dagardner-nv committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    b068686 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. naming things

    @dagardner-nv
    dagardner-nv committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    598b976 View commit details
    Browse the repository at this point in the history

  2. Building, TODO: look into adding name to WritableProvider

    @dagardner-nv
    dagardner-nv committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    faec661 View commit details
    Browse the repository at this point in the history

  3. WIP

    @dagardner-nv
    dagardner-nv committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5d534a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. wip

    @dagardner-nv
    dagardner-nv committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ec6c66e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. wip

    @dagardner-nv
    dagardner-nv committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7a45e24 View commit details
    Browse the repository at this point in the history

  2. wip

    @dagardner-nv
    dagardner-nv committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c79af3d View commit details
    Browse the repository at this point in the history

  3. Fix test_edges

    @dagardner-nv
    dagardner-nv committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4eff767 View commit details
    Browse the repository at this point in the history

  4. WIP

    @dagardner-nv
    dagardner-nv committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    10b3877 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Remove temporary skips

    @dagardner-nv
    dagardner-nv committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ca7ca50 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'david-named-nodes' into david-inconsistent-segments-and… 

    …-edges-named
    @dagardner-nv
    dagardner-nv committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c7edd3f View commit details
    Browse the repository at this point in the history

  3. IWYU fixes

    @dagardner-nv
    dagardner-nv committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    00f1549 View commit details
    Browse the repository at this point in the history

  4. Name held edges

    @dagardner-nv
    dagardner-nv committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    308968e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'david-named-nodes' into david-inconsistent-segments-and… 

    …-edges-named
    @dagardner-nv
    dagardner-nv committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    81a72fb View commit details
    Browse the repository at this point in the history

  6. Explicitly call constructor for SinkProperties since its a virtual an… 

    …cestor
    @dagardner-nv
    dagardner-nv committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9820993 View commit details
    Browse the repository at this point in the history

  7. Debug log

    @dagardner-nv
    dagardner-nv committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9d7b9d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Explicitly invoke SourceProperties ctor since its virtual

    @dagardner-nv
    dagardner-nv committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    e10afb3 View commit details
    Browse the repository at this point in the history

  2. WIP: Fixed segment init error tests

    @dagardner-nv
    dagardner-nv committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    e61179d View commit details
    Browse the repository at this point in the history

  3. Named queue's & release edges

    @dagardner-nv
    dagardner-nv committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a433e7e View commit details
    Browse the repository at this point in the history

  4. Only call shutdown on the builder when we are shutting down unexpecte… 

    …dly - all C++ tests passing
    @dagardner-nv
    dagardner-nv committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a0b6bda View commit details
    Browse the repository at this point in the history

  5. Set name

    @dagardner-nv
    dagardner-nv committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    96dda60 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Check to see if the disconnector has outlived the ForwardingEgressPro… 

    …vider
    @dagardner-nv
    dagardner-nv committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    111d7f8 View commit details
    Browse the repository at this point in the history

  2. Revert "Check to see if the disconnector has outlived the ForwardingE… 

    …gressProvider"

This reverts commit 111d7f8.
    @dagardner-nv
    dagardner-nv committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    96e76d6 View commit details
    Browse the repository at this point in the history

  3. Log all the things, TODO: remove

    @dagardner-nv
    dagardner-nv committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bcafc1c View commit details
    Browse the repository at this point in the history

  4. Add names and logs

    @dagardner-nv
    dagardner-nv committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d5150bb View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. WIP

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3a4358c View commit details
    Browse the repository at this point in the history

  2. Add additional test for connect & disconnect

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c0955b6 View commit details
    Browse the repository at this point in the history

  3. WIP: temp printing

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b0721e5 View commit details
    Browse the repository at this point in the history

  4. Avoid using the 'this' pointer in the disconnector method if the node… 

    … has already been destroyed, avoid using the m_parent if the node has been destroyed
    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    eebbcf6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'branch-23.11' of github.com:nv-morpheus/MRC into david-… 

    …inconsistent-segments-and-edges-named
    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1ac10d2 View commit details
    Browse the repository at this point in the history

  6. Use Mutext typedef

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    465c762 View commit details
    Browse the repository at this point in the history

  7. IWYU Fixes

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    897b33c View commit details
    Browse the repository at this point in the history

  8. Remove debug logging

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3108f2d View commit details
    Browse the repository at this point in the history

  9. Remove debug logging

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b9ff97a View commit details
    Browse the repository at this point in the history

  10. Parametarize the engine type

    @dagardner-nv
    dagardner-nv committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    2892329 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Remove unneeded using declatation. This caused errors with non-debug … 

    …builds
    @dagardner-nv
    dagardner-nv committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    6783187 View commit details
    Browse the repository at this point in the history

  2. formatting

    @dagardner-nv
    dagardner-nv committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4636694 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'branch-24.03' into david-inconsistent-segments-and-edge… 

    …s-named [no ci]
    @dagardner-nv
    dagardner-nv committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    67840a2 View commit details
    Browse the repository at this point in the history