Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Revert partially constructed segments on-error in segment init function #403

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Sep 29, 2023

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

…s different builds of llvm packages to fix CI
…nts check_active_connection from mistakenly returning true for a holder where init_owned_edge has been called but neither the init_connected_edge method or the add_connector method have not been called
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #403 (e3f243f) into branch-23.11 (ba483b1) will decrease coverage by 43.70%.
The diff coverage is 17.74%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-23.11     #403       +/-   ##
=================================================
- Coverage         73.62%   29.92%   -43.70%     
=================================================
  Files               385      309       -76     
  Lines             13613     9803     -3810     
  Branches           1029      858      -171     
=================================================
- Hits              10023     2934     -7089     
- Misses             3590     6869     +3279     
Flag Coverage Δ
cpp 29.92% <17.74%> (-39.79%) ⬇️
py ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cpp/mrc/include/mrc/manifold/interface.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/node/rx_runnable.hpp 63.63% <ø> (-18.19%) ⬇️
cpp/mrc/include/mrc/segment/object.hpp 32.40% <0.00%> (-19.05%) ⬇️
cpp/mrc/src/public/manifold/manifold.cpp 80.00% <0.00%> (-5.72%) ⬇️
cpp/mrc/include/mrc/manifold/egress.hpp 77.27% <50.00%> (-6.07%) ⬇️
cpp/mrc/include/mrc/manifold/ingress.hpp 63.63% <50.00%> (-7.80%) ⬇️
cpp/mrc/include/mrc/segment/component.hpp 0.00% <0.00%> (-100.00%) ⬇️
...pp/mrc/include/mrc/manifold/composite_manifold.hpp 82.05% <66.66%> (-4.62%) ⬇️
cpp/mrc/include/mrc/segment/runnable.hpp 42.85% <0.00%> (-40.48%) ⬇️
cpp/mrc/src/internal/segment/segment_instance.cpp 66.16% <0.00%> (-17.45%) ⬇️
... and 2 more

... and 275 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba483b1...e3f243f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DO NOT MERGE non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant