Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ControlMessage for PreProcessNLPStage PreProcessFILStage AddScoreStageBase #1573

Merged
merged 64 commits into from
Apr 7, 2024
Merged

Support ControlMessage for PreProcessNLPStage PreProcessFILStage AddScoreStageBase #1573

merged 64 commits into from
Apr 7, 2024

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Mar 21, 2024 •
edited
Loading

Description

Support ControlMessage as an input type for PreProcessNLPStage PreProcessFILStage AddScoreStageBase

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv self-assigned this Mar 21, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 21, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yczhang-nv yczhang-nv changed the title Support ControlMessage for PreProcess stages Support ControlMessage for PreProcessNLPStage PreProcessFILStage AddScoreStageBase Mar 27, 2024
@yczhang-nv yczhang-nv added breaking Breaking change non-breaking Non-breaking change and removed breaking Breaking change labels Mar 27, 2024
@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

4 similar comments
@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv yczhang-nv force-pushed the yuchen_support_cm_for_preprocess_stage branch from d75147e to 1d94c31 Compare April 5, 2024 00:15
@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

1 similar comment
@yczhang-nv
Copy link
Contributor Author

/ok to test

This was linked to issues Apr 5, 2024
[FEA]: Support ControlMessage types for AddClassificationStage and AddScoresStage #1547
Closed
[FEA]: Support ControlMessage types for PreprocessNLPStage and PreprocessFILStage #1546
Closed
@yczhang-nv yczhang-nv requested a review from a team as a code owner April 6, 2024 00:23
@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/ok to test

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 66e1768 into nv-morpheus:branch-24.03 Apr 7, 2024
9 checks passed
@yczhang-nv yczhang-nv deleted the yuchen_support_cm_for_preprocess_stage branch September 16, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@yczhang-nv yczhang-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
2 participants
@yczhang-nv @mdemoret-nv