-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ControlMessage
as an output type for HttpServerSourceStage
and HttpClientSourceStage
#1834
Open
dagardner-nv
wants to merge
56
commits into
nv-morpheus:branch-24.10
Choose a base branch
from
dagardner-nv:david-http-source-cm-1811
base: branch-24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support for ControlMessage
as an output type for HttpServerSourceStage
and HttpClientSourceStage
#1834
dagardner-nv
wants to merge
56
commits into
nv-morpheus:branch-24.10
from
dagardner-nv:david-http-source-cm-1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he 'accept_status' should not be used as it defaults to 201 which is the 'created' status
…the default the behavior remains the same, when true, the parse method will receive an additional argument of http headers
dagardner-nv
added
non-breaking
Non-breaking change
feature request
New feature or request
skip-ci
Optionally Skip CI for this PR
labels
Aug 7, 2024
2 tasks
…common to source stages which are able to emit either a message meta or control message
…ng tested [no ci]
dagardner-nv
changed the title
Support for
Support for Aug 8, 2024
ControlMessage
as an output type for HttpServerSourceStage
ControlMessage
as an output type for HttpServerSourceStage
and HttpClientSourceStage
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
message_type
,task_type
,task_payload
arguments toHttpServerSourceStage
&HttpClientSourceStage
.ConfigurableOutputSource
base class for single output source stages which support bothMessageMeta
andControlMessage
as output types.ControlMessage
output is selected, HTTP request headers will be added to the message's metadata.request_handler_fn_t
which receives the boost asio tcp endpoint along with the request object.HttpEndpoint
now optionally receives arequest_handler_fn_t
method, and for compatibility the olderpayload_parse_fn_t
method.include_headers
argument toHttpEndpointInterfaceProxy::init
, which whenFalse
(the default) uses the existingpayload_parse_fn_t
method, andrequest_handler_fn_t
whenTrue
. This changes the function signature, but not the behavior when theinclude_headers
argument is omitted, so technically not an API breaking change.cm_task_t
-->control_message_task_t
fromdeserialize.hpp
to be shared with other stagesControlMessage
which receives aMessageMeta
accept_status
for live and ready endpoints, as these should always return 200 on success, whileaccept_status
defaults to201 CREATED
which isn't appropriate for a health check.Includes isort fix from #1842
Closes #1811
By Submitting this PR I confirm: