Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure columns are strings before concatenation #1857

Merged
merged 5 commits into from
Sep 6, 2024
Merged

ensure columns are strings before concatenation #1857

merged 5 commits into from
Sep 6, 2024

Conversation

cwharris
Copy link
Contributor

Description

Closes #1849

Ensures all columns are string columns prior to attempting string concatenation in column_info.py.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@cwharris cwharris added bug Something isn't working non-breaking Non-breaking change labels Aug 22, 2024
@cwharris cwharris requested a review from a team as a code owner August 22, 2024 18:09
@cwharris cwharris requested a review from a team as a code owner August 22, 2024 20:10
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 667b51f into nv-morpheus:branch-24.10 Sep 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: DFP Pipeline fails after removing nv-tabular
2 participants
@cwharris @mdemoret-nv