-
Notifications
You must be signed in to change notification settings - Fork 133
Upgrade DELTACAST to native operators #1162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bhashemian
merged 30 commits into
nvidia-holoscan:main
from
deltacasttv:upgrade-deltacast-integration
Jan 12, 2026
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7fc5880
Add delta x370 board
thomasdethier b1ad50e
Add deltacast receiver
thomasdethier 5a949b7
Fix visualizer size
thomasdethier ede7c6b
Fix formatting
thomasdethier 44960eb
Update readme
thomasdethier f509554
Add python app
thomasdethier c621e3a
Update tested versions
thomasdethier b072bc1
WIP migration, compile ok
Isard7777 24a3cd3
Remove deltalcast_videomaster extension and related files from the pr…
Isard7777 a07878b
Remove no longer needed pool argument
Isard7777 532d688
Remove inheritance
Isard7777 8319dc4
Fix compilation
Isard7777 0af2324
Add logging, fix config and params
Isard7777 997af5d
Use tensor instead of video_buffer, add support for x370 board
thomasdethier 7219735
Transmitter now working (rdma and overlay not tested)
thomasdethier 1cfa557
Receiver now working (Rdma and overlay not tested)
thomasdethier 6428ad1
Fix multiple bugs regarding memory management
thomasdethier d8460e5
Fix non rdma mode
thomasdethier b08a2b7
Fix formatting
thomasdethier caf0071
Apply suggestions from code review
thomasdethier d07e306
Remove user-specific file
laurent-radoux c54735d
Enhance error handling, correct typos, improve doc
thomasdethier 09ac2e5
Refactor code and fix issues from review
thomasdethier 69caf8e
Refactor source block size calculations and enhance error handling in…
thomasdethier 17f94ec
Fix linting
thomasdethier 7363182
Fix typos, remove uneeded getter/setter, avoid polluting global scope…
thomasdethier de28164
Add Python subdirectory support in CMake configuration
thomasdethier 9475d31
Fix linting and copyright year
thomasdethier b851be8
Fix copyright year
thomasdethier 703cde0
Merge branch 'main' into upgrade-deltacast-integration
thomasdethier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,6 +33,7 @@ ci/ | |
| # Development environment | ||
| .venv/ | ||
| .vscode-server/ | ||
| .vscode/ | ||
| ngc-cli/ | ||
| CTestConfig.cmake | ||
| .ngc | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/adv_networking_bench_default_sw_loopback.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/adv_networking_bench_default_tx_rx.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/adv_networking_bench_default_tx_rx_hds.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/adv_networking_bench_default_tx_rx_multi_q_hds.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/adv_networking_bench_rdma_tx_rx.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/adv_networking_bench_rivermax_tx_rx.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/adv_networking_bench_rx_arb_match.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/cpp/testing/benchmark_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/cpp/testing/nvidia_nic_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/adv_networking_bench/cpp/testing/test_ano_bench.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
applications/basic_networking_ping/python/basic_networking_ping.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2022-2026, DELTACAST.TV. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| cmake_minimum_required(VERSION 3.20) | ||
| project(deltacast_receiver_apps LANGUAGES NONE) | ||
|
|
||
| add_subdirectory(cpp) | ||
|
|
||
| if(HOLOHUB_BUILD_PYTHON) | ||
| add_subdirectory(python) | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Deltacast Videomaster Receiver | ||
|
|
||
| This application demonstrates the use of videomaster_source to receive and display video streams from a Deltacast capture card using Holoviz for visualization. | ||
|
|
||
| ## Requirements | ||
|
|
||
| This application uses the DELTACAST.TV capture card for input stream. Contact [DELTACAST.TV](https://www.deltacast.tv/) for more details on how to access the SDK and setup your environment. | ||
|
|
||
| ## Build Instructions | ||
|
|
||
| See instructions from the top level README on how to build this application. | ||
| Note that this application requires to provide the VideoMaster_SDK_DIR if it is not located in a default location on the system. | ||
| This can be done with the following command, from the top level Holohub source directory: | ||
|
|
||
| ```bash | ||
| ./holohub build --local deltacast_receiver --configure-args="-DVideoMaster_SDK_DIR=<Path to VideoMasterSDK>" | ||
| ``` | ||
|
|
||
| ## Run Instructions | ||
|
|
||
| ### C++ Application | ||
|
|
||
| From the build directory, run the command: | ||
|
|
||
| ```bash | ||
| ./applications/deltacast_receiver/cpp/deltacast_receiver | ||
bhashemian marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
|
|
||
| ### Python Application | ||
|
|
||
| From the build directory, run the command: | ||
|
|
||
| ```bash | ||
| python3 applications/deltacast_receiver/python/deltacast_receiver.py | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2022-2026, DELTACAST.TV. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| cmake_minimum_required(VERSION 3.20) | ||
| project(deltacast_receiver CXX) | ||
|
|
||
| find_package(holoscan 1.0 REQUIRED CONFIG | ||
| PATHS "/opt/nvidia/holoscan" "/workspace/holoscan-sdk/install") | ||
|
|
||
| # CPP Application | ||
| add_executable(deltacast_receiver | ||
| main.cpp | ||
| ) | ||
|
|
||
| target_link_libraries(deltacast_receiver | ||
| PRIVATE | ||
| holoscan::core | ||
| holoscan::ops::format_converter | ||
| holoscan::ops::holoviz | ||
| holoscan::videomaster | ||
| ) | ||
|
|
||
| # Copy config file | ||
| add_custom_target(deltacast_receiver_yaml | ||
| COMMAND ${CMAKE_COMMAND} -E copy "${CMAKE_CURRENT_SOURCE_DIR}/deltacast_receiver.yaml" ${CMAKE_CURRENT_BINARY_DIR} | ||
| DEPENDS "deltacast_receiver.yaml" | ||
| BYPRODUCTS "deltacast_receiver.yaml" | ||
| ) | ||
| add_dependencies(deltacast_receiver deltacast_receiver_yaml) |
46 changes: 46 additions & 0 deletions
46
applications/deltacast_receiver/cpp/deltacast_receiver.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| %YAML 1.2 | ||
| # SPDX-FileCopyrightText: Copyright (c) 2022-2026, DELTACAST.TV. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| --- | ||
|
|
||
| deltacast: | ||
| width: 1920 | ||
| height: 1080 | ||
| progressive: true | ||
| framerate: 30 | ||
| board: 0 | ||
| input: 0 | ||
| rdma: false | ||
|
|
||
| format_converter: | ||
| in_dtype: "rgb888" | ||
| alpha_value: 255 | ||
| out_dtype: "rgba8888" | ||
| out_channel_order: [2,1,0,3] | ||
|
|
||
| drop_alpha_channel_converter: | ||
| in_dtype: "rgba8888" | ||
| out_dtype: "rgb888" | ||
| resize_height: 270 | ||
| resize_width: 480 | ||
|
|
||
| holoviz: | ||
| tensors: | ||
| - name: "" | ||
| type: color | ||
| opacity: 1.0 | ||
| priority: 0 | ||
| width: 480 | ||
| height: 270 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.