-
Notifications
You must be signed in to change notification settings - Fork 127
mmiranda nvidia style edits to surgical scene reconstruction #1329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
7ba449c
9c5ba36
cb9eb17
c5b9657
b8e97b9
3a688e5
183875e
4e982f8
5350154
1a71b0d
050a7e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,16 +1,15 @@ | ||||||||||
| # Surgical Scene Reconstruction with Gaussian Splatting | ||||||||||
|
|
||||||||||
| This application demonstrates real-time 3D surgical scene reconstruction by combining **Holoscan SDK** for high-performance streaming, **3D Gaussian Splatting** for neural 3D representation, and **temporal deformation networks** for accurate modeling of dynamic tissue. | ||||||||||
|
|
||||||||||
| Real-time 3D surgical scene reconstruction using Gaussian Splatting in a Holoscan streaming pipeline with temporal deformation for accurate tissue modeling. | ||||||||||
megnvidia marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||||||
| Real-time 3D surgical scene reconstruction using Gaussian Splatting in a Holoscan streaming pipeline with temporal deformation for accurate tissue modeling. |
megnvidia marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "uses cases" should be "use cases"
| It is ideal for use cases, such as: | |
| It is ideal for use cases, such as: |
megnvidia marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
megnvidia marked this conversation as resolved.
Show resolved
Hide resolved
megnvidia marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"run the surgical render" is awkward - not a standard technical term
| After training completes, to visualize your results in real-time, run the surgical render: | |
| After training completes, to visualize your results in real-time: |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is vague and doesn't add meaningful information. What "different aspects" does it refer to? Consider removing or making it more specific.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes a vague lead in -- twas my attempt to try to add some explanation for what the bullet list is trying to be. Ideal would be adding other words that help make the bullets make sense, but I need some feedback on what the list is trying to accomplish
megnvidia marked this conversation as resolved.
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent capitalization - "Gaussian" should be capitalized consistently with the rest of the document
| - Architecture: 3D Gaussian with learned position, scale, rotation, opacity, and color | |
| - Architecture: 3D Gaussians with learned position, scale, rotation, opacity, and color |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3D Gaussian should be 3D Gaussians (plural) to match the original description and be technically correct, as the model uses multiple Gaussian primitives.
| - Architecture: 3D Gaussian with learned position, scale, rotation, opacity, and color | |
| - Architecture: 3D Gaussians with learned position, scale, rotation, opacity, and color |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description incorrect - mentions MRI data and forecast future frames, but this application uses surgical endoscopy video for tissue reconstruction, not MRI
| The Temporal Deformation Network enables dynamic scene modeling by deforming the base Gaussian representations over time to accurately capture tissue movement and deformation during surgery. |
megnvidia marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description of the Temporal Deformation Network is inaccurate. It mentions "Temporal Generative Network (TGN)" generating "missing MRI data", but this application is for surgical endoscopy (not MRI), and the network performs real-time deformation (not data interpolation/forecasting). This description appears to be copied from an unrelated medical imaging context.
The description should match the actual functionality described in lines 146-150, which correctly describes the HexPlane-based deformation network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 120/126 the title of Model. What model are we talking here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@finalelement could you please help here?