Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref!(math-renderer): modularize image generation to make way for typst #1448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benlubas
Copy link
Contributor

More or less what it says on the tin.

Extracts the latex specific image generation code into it's own module, and provides that module as configuration to the (now called) math-renderer. This opens up the possibility of other math renderers, the most notable being typst.


Down the road, the norg file format will hopefully have some standard way of specifying the math language, and then this module can be reworked again to take that into account (and possibly render typst and latex in the same document). But for now, user configuration that allows rendering either latex or typst seems like a good starting point.

@vhyrro
Copy link
Member

vhyrro commented May 31, 2024

question: isn't this a breaking change, given the module name is now different?

@benlubas
Copy link
Contributor Author

benlubas commented May 31, 2024

yes, but the other one hasn't released yet.. and I already forgot that latex rendering existed before my PR to make it better lol.

Yea this should maybe be marked breaking

@benlubas benlubas changed the title ref(math-renderer): modularize image generation to make way for typst ref!(math-renderer): modularize image generation to make way for typst May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants