-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: links with relative path to parent directories #585
Conversation
Fixed headline autocompletion and jumping to files in parent or sibling directories.
I don't understand, why the tests do not run. I get a an error, that treesitter could not be found, when I try to run the tests locally. But I don't know, how this is supposed to work.
|
Did you install all dependencies? Here are instructions how to set up https://github.com/nvim-orgmode/orgmode/blob/master/CONTRIBUTING.md#tests |
@seflue could you please add a link to the emacs orgmode docs for the feature / bug you are addressing? Thanks |
My fault, I just found the instructions. Is it normal, that I have to stop the process with Ctrl-C after the tests ran? Or should it jump right back into console (what I would have expected)? |
The feature is org-open-at-point. Should I update the commit message? |
No, just a link to the orgmode manual / docs is sufficient. I presume this PR closes #583? |
I was able to find the reason why the tests broke. Within the autocompletion test the function using |
@jgollenz What do you think, can we merge it? I can't work without the fix anymore. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me, thanks!
Fixed headline autocompletion and jumping to files in parent or sibling directories. See also org-open-at-point in the Org manual. It solves issue #583.