Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links with relative path to parent directories #585

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

seflue
Copy link
Contributor

@seflue seflue commented Jun 27, 2023

Fixed headline autocompletion and jumping to files in parent or sibling directories. See also org-open-at-point in the Org manual. It solves issue #583.

Fixed headline autocompletion and jumping to files in parent or sibling directories.
@seflue
Copy link
Contributor Author

seflue commented Jun 27, 2023

I don't understand, why the tests do not run. I get a an error, that treesitter could not be found, when I try to run the tests locally. But I don't know, how this is supposed to work.

Error detected while processing /home/seflue/projects/nvim-orgmode/tests/minimal_init.vim:
line   21:
E5108: Error executing lua ./lua/orgmode/init.lua:69: module 'nvim-treesitter.parsers' not found:
        no field package.preload['nvim-treesitter.parsers']
        no file './nvim-treesitter/parsers.lua'
        no file '/usr/share/luajit-5_1-2.1.0-beta3/nvim-treesitter/parsers.lua'
        no file '/usr/local/share/lua/5.1/nvim-treesitter/parsers.lua'
        no file '/usr/local/share/lua/5.1/nvim-treesitter/parsers/init.lua'
        no file '/usr/share/lua/5.1/nvim-treesitter/parsers.lua'
        no file '/usr/share/lua/5.1/nvim-treesitter/parsers/init.lua'
        no file './nvim-treesitter/parsers.so'
        no file '/usr/local/lib/lua/5.1/nvim-treesitter/parsers.so'
        no file '/usr/lib64/lua/5.1/nvim-treesitter/parsers.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file './nvim-treesitter.so'
        no file '/usr/local/lib/lua/5.1/nvim-treesitter.so'
        no file '/usr/lib64/lua/5.1/nvim-treesitter.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        ./lua/orgmode/init.lua:69: in function 'setup_ts_grammar'
        [string ":lua"]:1: in main chunk
Error detected while processing command line:
E492: Not an editor command: TSUpdateSync org
E492: Not an editor command: PlenaryBustedDirectory tests/plenary/ {minimal_init = 'tests/minimal_init.vim'}

@kristijanhusak
Copy link
Member

Did you install all dependencies? Here are instructions how to set up https://github.com/nvim-orgmode/orgmode/blob/master/CONTRIBUTING.md#tests

@jgollenz
Copy link
Contributor

@seflue could you please add a link to the emacs orgmode docs for the feature / bug you are addressing? Thanks

@seflue
Copy link
Contributor Author

seflue commented Jun 28, 2023

Did you install all dependencies? Here are instructions how to set up https://github.com/nvim-orgmode/orgmode/blob/master/CONTRIBUTING.md#tests

My fault, I just found the instructions. Is it normal, that I have to stop the process with Ctrl-C after the tests ran? Or should it jump right back into console (what I would have expected)?

@seflue
Copy link
Contributor Author

seflue commented Jun 28, 2023

@seflue could you please add a link to the emacs orgmode docs for the feature / bug you are addressing? Thanks

The feature is org-open-at-point. Should I update the commit message?

@jgollenz
Copy link
Contributor

Should I update the commit message?

No, just a link to the orgmode manual / docs is sufficient. I presume this PR closes #583?

@seflue
Copy link
Contributor Author

seflue commented Jul 2, 2023

I was able to find the reason why the tests broke. Within the autocompletion test the function using vim.loop.fs_realpath is used - therefore it has to be mocked.

@seflue
Copy link
Contributor Author

seflue commented Jul 4, 2023

@jgollenz What do you think, can we merge it? I can't work without the fix anymore. 😉

Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me, thanks!

@kristijanhusak kristijanhusak merged commit 6f73b46 into nvim-orgmode:master Jul 4, 2023
@seflue seflue deleted the fix/hyperlinks branch July 4, 2023 16:33
SlayerOfTheBad pushed a commit to SlayerOfTheBad/orgmode that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants