Refactor/omnicompletion #620
Conversation
- make omni a proper module - split function omni into two separate methods - adjust all callers
The added tests cover the wrong behavior (start is one too short for using # after ::). When the bug get's fixed (or to expose it), the counter needs to be incremented by 1.
For finer granularity, which helps spotting bugs.
The regex is already hard enough to read. Because \w matches also digits and underscore, the explicit declarations of both are removed.
'#' is not a special character in vim regex. To simplify the hard-to-read regex for hyperlinks at least a little bit, we remove these escapings.
This type hint removes the annoying warning, when passing an url as an argument to context.fetcher.
seflue
force-pushed
the
refactor/omnicompletion
branch
from
36b0a3e to
0c23e22
Compare
| @@ -33,8 +32,8 @@ local properties = { | |||
| } | |||
|
|
|||
| local links = { | |||
| line_rgx = vim.regex([[\(\(^\|\s\+\)\[\[\)\@<=\(\*\|\#\|file:\)\?\(\(\w\|\/\|\.\|\\\|-\|_\|\d\)\+\)\?]]), | |||
| rgx = vim.regex([[\(\*\|\#\|file:\)\?\(\(\w\|\/\|\.\|\\\|-\|_\|\d\)\+\)\?$]]), | |||
| line_rgx = vim.regex([[\(\(^\|\s\+\)\[\[\)\@<=\(\*\|#\|file:\)\?\(\(\w\|\/\|\.\|\\\|-\)\+\)\?]]), | |||
There was a problem hiding this comment.
Why was this regex changed?
There was a problem hiding this comment.
I was hunting a bug (for which I currently only have a workaround), which I suspect to be in the regexp. Because of that I took a deeper dive into the regexp documentation and found out, that it was not the minimal regexp for what it tries to match. Some escapes are unnecessary and the \d and underscore were redundant, because they are already captured by \w. I tried to explain both simplifications in the corresponding commit message. Actually I always try to be as explicit as possible in my commits, so reading my commit messages can be very helpful when reviewing my PRs.
There was a problem hiding this comment.
Thanks for the clarification!
|
Thanks! |
Co-authored-by: Sebastian Flügge <[email protected]>
This PR decouples the two modes of omnicompletion, make them easier to understand and reuse. It also adds additional tests and includes some minor improvements (see the particular commits).