fix(virtual indent): do not return virtual indentation for headlines #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures when the treesitter parser has errors, the manual indent sizing doesn't return virtual indentation for headlines.
PriceHiller
force-pushed
the
fix/virtual-indent-offset
branch
from
7e04de0 to
0b21748
Compare
PriceHiller
changed the title
on_lines start & end by +1
kristijanhusak
approved these changes
Apr 10, 2024
SlayerOfTheBad
pushed a commit
to SlayerOfTheBad/orgmode
that referenced
this pull request
Aug 16, 2024
…vim-orgmode#716) This ensures when the treesitter parser has errors, the manual indent sizing doesn't return virtual indentation for headlines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from the body of the commit message:
Before the Fix
After the Fix
Misc
What's annoying is that the tests didn't catch this -- need a test to check raw insertion and typing I guess. That would've caught this for sure. The current tests loads the file, where the virtual indent works as expected.
Something to put on my TODO when I have more time.
Again, if anything crops up with Virtual Indent, ping me. I'll gladly look at it.