-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci, doc: add semver workflow and PR template #875
ci, doc: add semver workflow and PR template #875
Conversation
I'm not sure, but this might need a manifest to tell release-please about the initial version and which commit to bootstrap at. |
Hmm, I believe release-please just starts with the latest release version. Ie as soon as the workflow is merged and it runs, it'll automatically process all the commits pushed since the last release and add them to the release PR; and it'll start keeping track of semver bumps from the last release onwards. So it won't try to calculate the version number from the start of the repo history, If that's what you're worried about. Is this what you mean by telling it the initial version? (Thanks for your patience btw) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Lets just fix these few comments and then we'll give it a try.
7377040
to
614e6a8
Compare
Ok, I added the correct github token and changed the branch name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good. Let see how it goes.
Thanks!
Thank you! I'm very excited to have contributed. I hope the workflow and the PR template helps to make maintaining the repo a bit easier. Thanks for your hard work on this plugin! |
Summary
This PR adds a GitHub actions workflow to automate the creation of semantically versioned releases with
release-please
and a PR template to encourage compliance with conventional commits.Related Issues
Closes #828
Changes
release-please
workflowChecklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature
,fix: correct bug
,docs: update documentation
).make test
.