Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tags to search #17

Merged
merged 1 commit into from
May 24, 2024
Merged

feat: add tags to search #17

merged 1 commit into from
May 24, 2024

Conversation

seflue
Copy link
Collaborator

@seflue seflue commented May 24, 2024

To make the filtering more useful, enritch the search entries withorgmode tags. For usability reasons the tags appear before the headline, because the user might remember the tag before the actual headline. It also helps to remove ambiguities.

@seflue
Copy link
Collaborator Author

seflue commented May 24, 2024

@lyz-code we didn't talk about contribution conventions. Is it ok for you, if I just push improvements or do you want to be included as reviewer?

@lyz-code
Copy link
Collaborator

Hi @seflue, I absolutely have no idea of what I'm reading so I'd say that you go ahead with whatever you feel needs to be done.

I just did the fork because I wanted something that kind of worked, and I learned the minimal lua to do so.

So with the migration to the nvim-orgmode organization and your energy and knowledge, I'd say that I'd remove myself from the dev team and contribute only by opening issues.

Would that be ok for you?

@seflue
Copy link
Collaborator Author

seflue commented May 24, 2024

@lyz-code Sure, I'm absolutely fine with that. 👍

@seflue seflue merged commit a847849 into nvim-orgmode:main May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants