Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect file copied message (#37) #39

Closed
wants to merge 0 commits into from

Conversation

miguelmoraperea
Copy link
Contributor

When copying a file outside the original directory (cwd) the file is not
copied, this is expected, but the user still gets the following message:

[file] has been copied!

This is incorrect, this commit fixes the issue by verifying the result
status from the copy operation and prints the appropriate message
'[file] has been copied!' or '[file] has not been copied' depending on
whether the operation succeeded or not.

@fdschmidt93
Copy link
Member

Thanks for your PR :) Irrespective of the discussion on the original issue, this seems like a good change.

I'll try to test drive it and look into it soon.

@miguelmoraperea
Copy link
Contributor Author

I might've moved some branches in my forked repo, and it seems this PR got closed automatically, anyways I opened a new one:
#45

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants