Fix don't quote prompt when quote_char is empty string
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I already have a keymap to quote the prompt, so my current workflow is:
type query-> Quote prompt -> Start adding options
However I would like to create keymaps for some common options I use,
currently this not possible because when `quote_char` is emtpy, it still adds
backslashes before each character in prompt, and this breaks the search pattern
Usecase is for chaining mulitple `rg` options without, quoting
the prompt mulitple times, which is not the expected behavior when
`quote_char` is empty string.
E.g Consider this keymap
```lua
["<C-;>"] = require("telescope-live-grep-args.actions").quote_prompt {
postfix = " --word-regexp ",
quote_char = "",
}
```
And I search for `tab`, then pressing `<C-;>`:
Before:
```
\"\t\a\b\"\ --word-regexp
```
After:
```
"tab" --word-regexp
```
rafamadriz
force-pushed
the
fix-quote-prompt
branch
from
0f87ed5
to
4ca7a9c
Compare
rafamadriz
added a commit
to rafamadriz/dotfiles
that referenced
this pull request
May 29, 2023
Revert to upstream when <nvim-telescope/telescope-live-grep-args.nvim#59> is merged. Ref: 81c1310
rafamadriz
added a commit
to rafamadriz/dotfiles
that referenced
this pull request
May 29, 2023
Revert to upstream when <nvim-telescope/telescope-live-grep-args.nvim#59> is merged. Ref: 81c1310
rafamadriz
added a commit
to rafamadriz/dotfiles
that referenced
this pull request
Jun 3, 2023
Revert to upstream when <nvim-telescope/telescope-live-grep-args.nvim#59> is merged. Ref: 81c1310
|
Hello, I would definitively need that feature too! Any chance of merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already have a keymap to quote the prompt, so my current workflow is: type query-> Quote prompt -> Start adding options
However I would like to create keymaps for some common options I use, currently this not possible because when
quote_charis emtpy, it still adds backslashes before each character in prompt, and this breaks the search patternUsecase is for chaining mulitple
rgoptions without, quoting the prompt mulitple times, which is not the expected behavior whenquote_charis empty string.E.g Consider this keymap
And I search for
tab, then pressing<C-;>:Before:
After: