Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin.live_grep, builtin.treesitter): not adding jumps to jumplist #3175

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

xz47sv
Copy link
Contributor

@xz47sv xz47sv commented Jun 17, 2024

Description

Whenever a picker, that can jump to a different location in the same buffer does so it should have push_cursor_on_edit otherwise the jump won't be recorded.

Maybe this affects other pickers too, but I only noticed it on grep and treesitter since I use those two a lot.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

Whenever a picker, that can jump to a different location in the same buffer does so it should have `push_cursor_on_edit` otherwise the jump won't be recorded.

Maybe this affects other pickers too, but I only noticed it on grep and treesitter since I use those two a lot.
@jamestrew
Copy link
Contributor

I think this makes sense.
Can you also add it for grep_string while we're at it?

@xz47sv
Copy link
Contributor Author

xz47sv commented Jun 23, 2024

added

@jamestrew jamestrew merged commit af78ba3 into nvim-telescope:master Jun 25, 2024
12 checks passed
@jamestrew
Copy link
Contributor

Thanks!

@jamestrew jamestrew added the backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat) label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-0.1.x PR to be backported to 0.1.x (Neovim 0.7 compat)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants