feat: ungrouping empty directories #2647
Conversation
|
This works:
|
There was a problem hiding this comment.
This is a change in behaviour that will interrupt current users. Also, group empty has historically been problematic and we need to reduce the blast radius.
Options:
- Add a new option, defaulting off
- Add API to specifically map a key to "expand the empties"
2 is preferable as it offers the greatest flexibility and ease of use.
@juefeiyan are you up to the challenge of 2?
lua/nvim-tree/lib.lua
Outdated
| return node.nodes | ||
| end | ||
|
|
||
| ---Group empty folders |
There was a problem hiding this comment.
Group->ungroup and longer description please.
There was a problem hiding this comment.
sure, will resolve the comments and working on option 2
There was a problem hiding this comment.
Just pushed a new version and implemented option 2, please take a look if you are free
juefeiyan
force-pushed
the
feat/ungroup-empty-folder
branch
from
d036b06 to
ac0e540
Compare
|
A test case like |
doc/nvim-tree-lua.txt
Outdated
| @@ -1848,6 +1849,9 @@ node.open.vertical() *nvim-tree-api.node.open.vertical()* | |||
| node.open.horizontal() *nvim-tree-api.node.open.horizontal()* | |||
| |nvim-tree-api.node.edit()|, file will be opened in a new horizontal split. | |||
|
|
|||
| node.open.toggle_grouped_folders() *nvim-tree-api.node.open.toggle_grouped_folders()* | |||
There was a problem hiding this comment.
This is actually specific - it groups/ungroups one folder and somewhat persists that, which is desirable.
Perhaps:
*nvim-tree-api.node.open.toggle_group_empty()*
node.open.toggle_group_empty()
Toggle |nvim-tree.renderer.group_empty| for a specific folder.
Does nothing on files.
Needs |nvim-tree.renderer.group_empty| set.
There was a problem hiding this comment.
thanks for the nice name
doc/nvim-tree-lua.txt
Outdated
| @@ -2196,6 +2200,7 @@ You are encouraged to copy these to your own |nvim-tree.on_attach| function. | |||
| vim.keymap.set('n', 'I', api.tree.toggle_gitignore_filter, opts('Toggle Filter: Git Ignore')) | |||
| vim.keymap.set('n', 'J', api.node.navigate.sibling.last, opts('Last Sibling')) | |||
| vim.keymap.set('n', 'K', api.node.navigate.sibling.first, opts('First Sibling')) | |||
| vim.keymap.set('n', 'L', api.node.open.toggle_grouped_folders,opts('Toggle Grouped Folders')) | |||
There was a problem hiding this comment.
| vim.keymap.set('n', 'L', api.node.open.toggle_grouped_folders,opts('Toggle Grouped Folders')) | |
| vim.keymap.set('n', 'L', api.node.open.toggle_grouped_folders,opts('Toggle Group Empty')) |
L seems like the only viable mapping.
Hi @alex-courtis , I jsut solved your comments, please take a look at my new MR |
|
This is looking great - files are indeed a NOP. Sorry to be a pain; I have one more request: I don't know if this is practical - please advise. |
great suggestion, I just implement it, please take a look |
|
Thank you! I think I asked for a similar feature a long time ago, but I can't find any issue or discussion about it at the moment. |
implement #2646
change: if users enabled group_empty, there would be three states when users 'expand_or_collapse' a grouped folders:
1: closed grouped folder:
2: opened grouped folder:
3: opened ungrouped folder:
that feature would allow users to add files/folders in the middle grouped empty folder.