feat(#2630): file renames can now create directories #2657
Conversation
|
Many thanks, I'll get to this on the weekend. |
There was a problem hiding this comment.
Please accept my apologies for not reviewing this earlier; this slipped off my list.
Unfortunately I'm not able to get anything working, including existing rename functionality, I think I'm Doing It Wrong. What OS / shell are you using?
Full rename testing using linux source:
-
CREDITS->usr/CREDITS-usr/CREDITSdirectory created, file not moved -
Makefile->usr/Makefile- success reported, file not moved, should report: [NvimTree] Cannot rename Makefile -> Makefile: file already exists -
Makefile->foo/Makefile-foo/Makefiledirectory created, file not moved -
README->foo/bar/README-foo/bar/READMEcreated, file not moved -
README->READMEEEE- directoryREADMEEEEcreated, file not moved -
usr/default_cpio_list->usr/default_cpio_listtt- directoryusr/default_cpio_listttcreated, file not moved
Events appear to be correctly sent.
| idx = idx + 1 | ||
|
|
||
| local p = utils.path_remove_trailing(path) | ||
| if #path_to_create == 0 and vim.fn.has "win32" == 1 then |
There was a problem hiding this comment.
Please use utils.is_wsl or utils.is_windows
There was a problem hiding this comment.
I'm using wezterm terminal running zsh on macOS. I'll change the wsl, windows check on rename.
Should I change it in the create file because it is like what I've done right now?
I'll check into why this is failing :)
There was a problem hiding this comment.
I'm using wezterm terminal running zsh on macOS. I'll change the wsl, windows check on rename. Should I change it in the create file because it is like what I've done right now? I'll check into why this is failing :)
My apologies, I didn't realise it came from copy. That's fine, no need to change.
We need a big refactor / abstraction for that functionality, but Not Today.
I'd be very grateful for a future PR to do that :)
…as the file and forgot to remove it
|
It's not fixed right now and shall reopen this PR after I've fixed the errors :) |
Hey no worries, take all the time you need. I look forward to using this functionality... |
…values as they were mismatched
|
Now the code does indeed work and has been tested. Not many changes have been made since the closing of this PR but now it seems to work at least on my device. My device: |
|
I've tested it on a vm and the functionality seems to be working VM: The renaming and directory creating functionality is working as intended and does not seem to create a directory instead of a file anymore |
|
Thanks for reopening. I'll get to review and test on the weekend. |
|
Looking good: Full rename
Rename
Rename basename
Rename omit filename
|
alex-courtis
changed the title
I've implemented this feature.
I've just used the same code from create file as mentioned in the issue so as to not break any convention that was followed.
Any input is appreciated! :)