fix(#111): resolve windows executable paths

[barrett-ruth]

resolves #111 - uv.spawn() fails to detect programs as executable on windows. Use exepath() to resolve paths before spawn.

[barrett-ruth]

@UnderCooled check this out and make sure it works - thanks.

[UnderCooled]

@barrett-ruth It works, hope this won't cause problems on other OSes.

[xiaoshihou514]

Seems fine on my linux machine 👍

[UnderCooled]

Sorry, this fix does cause a problem...

If you have two linters, when the second one runs, it raises E5560: Vimscript function must not be called in a lua loop callback.

guard.nvim/lua/guard/lint.lua

Lines 29 to 30 in 192fd1d

	lint.lines = prev_lines
	local data = spawn(lint)

      lint.cmd = vim.fn.exepath(lint.cmd)
      local data = spawn(lint)

After I add exepath there, no more E5560, but the second linter won't show diag messages. I've checked that with either one only, it worked.

[xiaoshihou514]

Maybe schedule it...? Would take a deeper look this weekend.

[barrett-ruth]

@UnderCooled can you try his suggested approach. Also, if you could draft up a PR that would be great - I personally dont't have a windows device to test any changes on.

[xiaoshihou514]

Yes, a pr would be great. Doesn't own a windows machine either :(
Also some tests for linters would be great 🤔 Just a thought

[UnderCooled]

The second linter not running is another issue, this Windows ".cmd" fix (exepath) could be moved to do_lint before uv.spawn call. I don't know how to write an unit test for this vim standard function, its behavior should be tested in Vim/Neovim already.

Maybe I should open another issue about the second linter? Will that be related to issue #113?