Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LoadGen RegisterIssueQueryThread() #1

Open
wants to merge 2 commits into
base: dev-loadgen-server-max-qps
Choose a base branch
from
Open

Implement LoadGen RegisterIssueQueryThread() #1

wants to merge 2 commits into from

Conversation

nvpohanh
Copy link
Owner

@nvpohanh nvpohanh commented Jun 15, 2020 •
edited
Loading

This is built on top of: mlcommons#618

Changes:

  • Added a new TestSettings flag: server_num_issue_query_threads.
  • Implemented multi-thread IssueQuery() functionality in issue_query_controller.cc/h. This feature is enabled only when in Server scenario, server_num_issue_query_threads is set to positive numbers, and if there are threads calling RegisterIssueQueryThread().
  • Moved SampleMetadata, QueryMetadata, ResponseDelegate, QueryScheduler implementations and part of IssueQueries() to issue_query_controller.cc/h with very minor modifications.

tjablin
tjablin suggested changes Jun 15, 2020
View reviewed changes
loadgen/benchmark/repro.cpp Show resolved Hide resolved
loadgen/benchmark/repro.cpp Outdated Show resolved Hide resolved
@nvpohanh nvpohanh mentioned this pull request Jun 15, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjablin tjablin tjablin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvpohanh @tjablin