Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuous executor #188

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

continuous executor #188

wants to merge 3 commits into from

Conversation

mildred
Copy link
Contributor

@mildred mildred commented Mar 8, 2023

@nwg-piotr
Copy link
Owner

nwg-piotr commented Mar 9, 2023

We also need a check button in the config gui, together with a tooltip, containing some good explanation what "Continuous" means. We don't want users to edit config files manually.

@mildred
Copy link
Contributor Author

mildred commented Mar 9, 2023

Implemented GUI (I thought that was another package) and also fixes GUI in relation to #184

@nwg-piotr
Copy link
Owner

What about #190?

@mildred
Copy link
Contributor Author

mildred commented Mar 13, 2023

I'm going to look at #190, thank you for bringing it up. I'll probably make another PR as this is an entirely different module.

@mildred
Copy link
Contributor Author

mildred commented Mar 13, 2023

This is in #191

@moetayuko
Copy link
Contributor

@nwg-piotr
Copy link
Owner

  1. shlex.split has been deprecated since python 3.9;
  2. I'd like to see an example of an executor that will benefit from being "continuous".

@progandy
Copy link
Contributor

  1. shlex.split has been deprecated since python 3.9;

That is not entirely correct. I read it as only the special behaviour with s=None is deprecated, normal string splitting is not.
python/cpython#77443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants