Remove invalid upstreams #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes upstream attribute for projects, whose revisions points to tag or branch.
Upstream attribute is intended to be used when revision point to hash of commit, to aid the commit search in git.
If revision point to tag, the upstream attribute is not used in case if you just call repo sync.
If you try to pin manifest using
repo manifest -r -o pinned-manifest.xmlit will reuse the upstream without checking.Which will lead to errors, if upstream attribute is invalid.
When I tried to pin manifest for our project I have discovered that
<project name="meta-imx" remote="imx" path="sources/meta-imx" revision="refs/tags/rel_imx_6.12.34_2.1.0" upstream="walnascar-6.12.34.2.1.0">has invalid upstream and walnascar-6.12.34.2.1.0 doesn't exist. Probably a typo(note the dot-dash difference): walnascar-6.12.34-2.1.0.
But since upstream shouldn't be there when revision doesn't point to commit hash - let's remove them.