Fix and rename Config::find
to Config::filter
#452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always scratched my head looking at
Config Config::find(const string &pro)
, wondering about its purpose. If I don't misinterpret it it creates a new instance ofConfig
- holding all defaultConfigItem
s and then adds the ones of the current instance additionally which fit the passed protocol.Since I guess it should rather filter I modified the
Config
constructor to allow creating an instance without anyConfigItem
s and then adding just selected ones within thefilter
function.