Skip to content

Restore Windows --dev source selection#363

Closed
tsosunchia wants to merge 1 commit into
mainfrom
codex/restore-windows-dev-source-ip
Closed

Restore Windows --dev source selection#363
tsosunchia wants to merge 1 commit into
mainfrom
codex/restore-windows-dev-source-ip

Conversation

@tsosunchia

Copy link
Copy Markdown
Member

Summary

  • Restore Windows --dev behavior so selected devices resolve to a source IP instead of rejecting TCP probes
  • Update CLI help, README, and project notes to describe Windows --dev as source-address selection rather than real interface binding
  • Keep the existing source-device normalization tests aligned with the restored behavior

Testing

  • go test ./trace ./cmd
  • go test ./...

Keep Windows --dev usable by resolving the selected device to a source IP and clearing SourceDevice before the tracer reaches Windows send paths. Update docs and project notes to describe that Windows routing may still choose the actual egress interface.
@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9f63398-c9d7-4cd4-a49a-49a748490927

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/restore-windows-dev-source-ip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tsosunchia tsosunchia closed this Apr 20, 2026
@tsosunchia tsosunchia deleted the codex/restore-windows-dev-source-ip branch April 20, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant