Skip to content

Conversation

norkans7
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 09:25
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the test infrastructure to use the official minio/minio Docker image instead of the bitnami/minio image, and modernizes the S3 client implementation by switching to the s3x service wrapper.

  • Replaces bitnami/minio service with official minio/minio Docker container in CI
  • Updates test setup to use s3x.NewService instead of direct S3 client creation
  • Adds proper bucket lifecycle management with setup and teardown functions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yml Replaces bitnami/minio service with minio/minio Docker container using explicit docker run command
archives/archives_test.go Updates S3 client initialization, adds bucket management, and implements teardown cleanup for all tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@norkans7 norkans7 changed the base branch from update-minio to main September 18, 2025 09:26
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.93%. Comparing base (c01db89) to head (3c63a0d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   59.16%   58.93%   -0.23%     
==========================================
  Files           7        7              
  Lines        1310     1310              
==========================================
- Hits          775      772       -3     
- Misses        429      434       +5     
+ Partials      106      104       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rowanseymour
Copy link
Member

@norkans7 ah darn I didn't notice this and did it myself - btw instead of doing defer tearDown you can attach cleanup methods to testing.T with t.Cleanup(...)

@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants