Skip to content

Conversation

rowanseymour
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 18:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated path JSON column from the flows_flowrun table and fully migrates to the newer path_nodes and path_times array columns for storing flow run path data.

  • Removes the path column from the flows_flowrun table schema
  • Updates test data to use path_nodes and path_times arrays instead of JSON path format
  • Simplifies the archive query to only use the new array-based path format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
testdb.sql Removes path column from table schema and converts INSERT statements to use array-based path format
archives/runs.go Simplifies path query logic by removing fallback to deprecated JSON path column

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.11%. Comparing base (29ba3ed) to head (fadc588).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   59.11%   59.11%           
=======================================
  Files           7        7           
  Lines        1311     1311           
=======================================
  Hits          775      775           
  Misses        430      430           
  Partials      106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rowanseymour rowanseymour merged commit c7abe17 into main Sep 18, 2025
7 checks passed
@rowanseymour rowanseymour deleted the no_more_path branch September 18, 2025 18:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant