-
Notifications
You must be signed in to change notification settings - Fork 19
Tw 3961 v 3 java sdk grant id isnt included in the get folders response #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tw 3961 v 3 java sdk grant id isnt included in the get folders response #298
Conversation
- Add select parameter to ListMessagesQueryParams, FindMessageQueryParams, ListThreadsQueryParams, FindThreadQueryParams, ListContactsQueryParams, FindContactsQueryParams, ListEventQueryParams, FindEventQueryParams, ListCalendersQueryParams, FindCalendarQueryParams, and FindAttachmentQueryParams - Create new FindFolderQueryParams, FindThreadQueryParams, and FindCalendarQueryParams classes - Update Folders, Threads, and Calendars resources to accept query parameters in find methods - Make model properties (grantId, id, etc.) optional in Message, Contact, Event, Thread, Folder, and Calendar models to support select functionality - Add comprehensive tests ensuring backward compatibility - Update examples to demonstrate select parameter usage Fixes issue where grant_id wasn't included in responses when using select parameter, preventing model deserialization errors.
- Add SelectParameterDeserializationTests to verify models handle missing fields correctly - Add SelectParameterIntegrationTests to verify query parameter handling - Add comprehensive SelectParameterExample demonstrating usage across all endpoints - Fix nullable field access in EventsTests to prevent compilation errors - Update CHANGELOG.md with test coverage and examples information All specified endpoints already have select parameter support and work correctly. The reported grant_id issue appears to be resolved as deserialization properly handles missing fields when using select parameter.
Pull Request SummaryThis pull request introduces several changes aimed at improving the flexibility and performance of the Nylas SDK by allowing clients to request only specific fields in API responses, thereby reducing payload size and latency. Here are the key changes:
Overall, these changes aim to enhance the SDK's performance and flexibility by allowing clients to tailor API responses to their specific needs, reducing unnecessary data transfer and processing. Files Changed
View more in PlayerZero |
nylas + PlayerZeroView more in PlayerZero |
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.