Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook triggers to bypass ValueErrors #406

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

kraju3
Copy link
Contributor

@kraju3 kraju3 commented Jan 31, 2025

Description

We were missing some webhook triggers which caused ValueErrors while customers tried to use our Webhooks API via the SDK.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Contributor

@AaronDDM AaronDDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests that need to be updated?

@kraju3
Copy link
Contributor Author

kraju3 commented Jan 31, 2025

@AaronDDM There is deserialization test but I just added one that covers the entire list

@AaronDDM AaronDDM merged commit 5365f6a into nylas:main Apr 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants