Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAuth URL building #462

Merged

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Feb 8, 2024

Fix url_auth_builder call

Description

This line:

builder.query = URI.encode_www_form(build_query(config)).gsub!("+", "%20")

Replaces the whole value, so the Auth doesn’t work.

Replaced it with this:

builder.query = URI.encode_www_form(build_query(config)).gsub(/\+/, "%20")

https://nylas.atlassian.net/browse/TW-2543

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Fix url_auth_builder call
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eeb47e8) 99.84% compared to head (1378047) 99.84%.

❗ Current head 1378047 differs from pull request most recent head db13ed0. Consider uploading reports for the commit db13ed0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files          24       24              
  Lines         664      658       -6     
==========================================
- Hits          663      657       -6     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrashed-dev mrashed-dev changed the title Update auth.rb Fix OAuth URL building Feb 8, 2024
@mrashed-dev mrashed-dev merged commit 740631d into main Feb 8, 2024
5 checks passed
@mrashed-dev mrashed-dev deleted the TW-2543-Ruby-SDK---url_auth_builder-not-working-properly branch February 8, 2024 16:03
@mrashed-dev mrashed-dev mentioned this pull request Feb 12, 2024
mrashed-dev added a commit that referenced this pull request Feb 12, 2024
# Changelog
* Fixed a bug during OAuth URL building (#462)
* Fixed a bug where the `next_cursor` field was omitted for list responses (#461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants