Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grants.rb add Patch #464

Merged

Conversation

atejada
Copy link
Contributor

@atejada atejada commented Feb 15, 2024

Description

Add Patch operation, as it is needed when doing Update Grant

https://nylas.atlassian.net/browse/TW-2578

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Add Patch operation, as it is needed when doing Update Grant
Test should use patch instead of put for grants update
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0be4370) 99.84% compared to head (48bb94e) 99.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          24       24           
  Lines         664      665    +1     
=======================================
+ Hits          663      664    +1     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrashed-dev mrashed-dev merged commit 7c619b5 into main Feb 21, 2024
7 checks passed
@mrashed-dev mrashed-dev deleted the TW-2578-Ruby-SDK---Patch-is-missing-from-Grants-operation branch February 21, 2024 17:43
@mrashed-dev mrashed-dev mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants