Move Detect Provider from Auth to Connectors #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Detect Provider is on Auth, but it should be on Connectors
Looks it needs to in both places
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
- Coverage 99.84% 99.69% -0.15%
==========================================
Files 24 24
Lines 664 666 +2
==========================================
+ Hits 663 664 +1
- Misses 1 2 +1 ☔ View full report in Codecov by Sentry. |
|
No longer needed as we are not moving detect provider. |
mrashed-dev
deleted the
TW-2599-Ruby-SDK---Detect-provider-should-be-in-Connectors-not-Auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Detect Provider is on Auth, but it should be on Connectors too
https://nylas.atlassian.net/browse/TW-2599
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.